refactor!: refine extension startup flow #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of the on_configure() initialization phase, the startup process of the extension has been better planned. - on_configure ~ on_configure_done + on_init ~ on_init_done: Handles its own initialization; cannot send or receive messages. The reason for this is that, before `on_init_done`, the extension may not be ready to handle external requests, so the received messages need to be temporarily stored. - ~ on_start: The messages received before on_start() will be temporarily stored, and only after on_start() is called will they be sent to the extension. The reason for this is developers generally expect `on_start` to occur before any `on_cmd` events. - on_start ~ on_stop_done: Normal sending and receiving of all messages and results. BREAKING CHANGE: The initialization actions that were originally performed in on_start() need to be moved to on_init(). This is because once on_start() is called, on_cmd() will start being received.
halajohn
changed the title
With the introduction of the on_configure() initialization phase, the startup process of the extension has been better planned. - on_configure ~ on_configure_done + on_init ~ on_init_done: Handles its own initialization; cannot send or receive messages. The reason for this is that, before `on_init_done`, the extension may not be ready to handle external requests, so the received messages need to be temporarily stored. - ~ on_start: The messages received before on_start() will be temporarily stored, and only after on_start() is called will they be sent to the extension. The reason for this is developers generally expect `on_start` to occur before any `on_cmd` events. - on_start ~ on_stop_done: Normal sending and receiving of all messages and results. BREAKING CHANGE:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.