Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: $_GET['from'] ? #354

Closed
jrfnl opened this issue Apr 26, 2015 · 1 comment · Fixed by #363
Closed

Question: $_GET['from'] ? #354

jrfnl opened this issue Apr 26, 2015 · 1 comment · Fixed by #363

Comments

@jrfnl
Copy link
Contributor

jrfnl commented Apr 26, 2015

I encountered the below bit of code, but can't seem to find any other reference in the code base to the 'from' variable. By the looks of it, the code has been in the repo from the second commit.

Anyone any idea what this is about ?

Ref: https://github.com/thomasgriffin/TGM-Plugin-Activation/blob/develop/class-tgm-plugin-activation.php#L544-L546

if ( isset( $_GET['from'] ) ) {
    $url .= add_query_arg( 'from', urlencode( stripslashes( $_GET['from'] ) ), $url );
}
@GaryJones GaryJones added this to the 2.5.0 milestone Apr 27, 2015
@GaryJones
Copy link
Member

I can only assume it was meant to track where the plugin was coming from (source), but I can't see that it was used anywhere.

We don't appear to use it now, so delete the instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants