Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Develop] Allow other plugins to filter the action links similar to WP Core. #226

Closed
wants to merge 2 commits into from

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Sep 23, 2014

No description provided.

@thomasgriffin
Copy link
Contributor

This looks fine, but I don't like have a prefixed filter based on network admin. I would rather have one filter and then the dev determine whether or not to adjust based on multisite.

@jrfnl
Copy link
Contributor Author

jrfnl commented Jan 2, 2015

@thomasgriffin Thanks for your response. I've changed the PR to reflect your remark. All the same, the only reason I did it that way is to stay in line with the WP core handling of the same.

@thomasgriffin
Copy link
Contributor

Would you mind creating this pull request against the master branch? I've not done anything with the develop branch in a while. Indeed, I need to actually remove it as it doesn't quite make sense for this repo.

@jrfnl jrfnl changed the title Allow other plugins to filter the action links similar to WP Core. [Develop] Allow other plugins to filter the action links similar to WP Core. Jan 13, 2015
@GaryJones
Copy link
Member

Indeed, I need to actually remove it as it doesn't quite make sense for this repo.

@thomasgriffin Why are you planning to remove the develop branch? That's a really bad decision IMO.

@GaryJones
Copy link
Member

+1 to the filter.

@jrfnl
Copy link
Contributor Author

jrfnl commented Jan 23, 2015

@thomasgriffin Why are you planning to remove the develop branch? That's a really bad decision IMO.

@GaryJones Not just your HO, I concur.

@GaryJones
Copy link
Member

I'd prefer to see the hooks named as tgmpa_plugin_action_links and tgmpa_network_admin_plugin_action_links.

This follows the core convention for naming of those action links hooks, but with our prefix before it, and consistently using underscores.

@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 22, 2015

@GaryJones The original commit literally followed what core did, @thomasgriffin however didn't agree...

@GaryJones
Copy link
Member

I know, and #300 is a slightly more correct variation (order of prefixes, interpolation) on what you proposed. If you agree, then merge it.

Closing in favour of #300.

@GaryJones GaryJones closed this Apr 22, 2015
@jrfnl jrfnl deleted the filter-action-links branch April 22, 2015 06:15
@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 22, 2015

I agree & merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants