-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Develop] Allow other plugins to filter the action links similar to WP Core. #226
Conversation
This looks fine, but I don't like have a prefixed filter based on network admin. I would rather have one filter and then the dev determine whether or not to adjust based on multisite. |
9e82af1
to
bf6f910
Compare
@thomasgriffin Thanks for your response. I've changed the PR to reflect your remark. All the same, the only reason I did it that way is to stay in line with the WP core handling of the same. |
Would you mind creating this pull request against the master branch? I've not done anything with the develop branch in a while. Indeed, I need to actually remove it as it doesn't quite make sense for this repo. |
@thomasgriffin Why are you planning to remove the develop branch? That's a really bad decision IMO. |
+1 to the filter. |
@GaryJones Not just your HO, I concur. |
I'd prefer to see the hooks named as This follows the core convention for naming of those action links hooks, but with our prefix before it, and consistently using underscores. |
@GaryJones The original commit literally followed what core did, @thomasgriffin however didn't agree... |
I agree & merged. |
No description provided.