-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Develop] Add travis script #304
Conversation
Also: - only show `var_dump()` when `WP_DEBUG` is set to `true`
Conflicts: class-tgm-plugin-activation.php
# Might as well test HHVM too | ||
- hhvm | ||
# Lowest currently possible in travis | ||
- 5.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't Travis only support 5.3 min now?
What about 5.3, 5.4, 5.5? Occasionally something breaks there, and currently we would only know that it passed the low PHP level, but failed at 5.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure they reverted the removal of PHP 5.2 (under pressure of the WP community).
As we're currently only doing a lint and phpcs, running it on more versions would be wasting resources as the results won't change. If it breaks on either of those two versions, we need to look at the code, everything in between is caught by this.
Once we have unit tests, we should start running it on more versions, though still only lint and phpcs on highest and lowest.
I think the addition of |
…ion into develop-travis
I'll keep that in mind for that future. In this case I think they are related (except for the concatenation commit which was just extra). Adding the travis script which runs phpcs and will fail straight away on errors would mean that the travis config could not be merged. (providing we'll hook it in now to test this PR before merge) |
…ion into develop-travis Conflicts: class-tgm-plugin-activation.php
Updated PR |
Add Travis-CI script, fix PHPCS errors
@GaryJones shouldn't we hook travis in first to test this PR ? |
It will get tested once we are hooked up - we can adjust it from there. |
Needs IRL test
Also:
phpcs.xml
toruleset.xml
so PHPStorm can pick it upvar_dump()
on error whenWP_DEBUG
is set totrue