Abstract duplicate code to retrieve a download url #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return string Plugin download URL or path to local file | ||
| */ | ||
| public function get_download_url( $slug ) { | ||
| $dl = ''; |
There was a problem hiding this comment.
Scrutinizer will likely pick up on this as being too short a variable name. $download_url or $url would be a little more descriptive.
There was a problem hiding this comment.
Hmm.. but $url would be wrong as it can be a path just as easily... which is why I went with $dl ;-)
There was a problem hiding this comment.
Then the function name is misleading too :-)
- return early - variable name > 2 chars - update documentation
|
Updated the PR |
GaryJones
added a commit
that referenced
this pull request
Apr 28, 2015
…oad-url Abstract duplicate code to retrieve a download url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.