Document the tgmpa_load filter and reverse its logic ...
#388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e logical in use. Previously `false` had to be returned for TGMPA to load which was confusing. This shouldn't cause issues for "existing implementations" as the filter has only been introduced a week ago and I doubt there are any existing implementations yet.
GaryJones
added a commit
that referenced
this pull request
May 4, 2015
…logic Document the `tgmpa_load` filter and reverse its logic ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to make it more logical in use.
Previously
falsehad to be returned for TGMPA to load which would be confusing for people implementing it.This shouldn't cause issues for "existing implementations" as the filter has only been introduced a week ago and I doubt there are any existing implementations yet.