Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the example plugin. #557

Merged
merged 1 commit into from
Apr 19, 2016
Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Apr 1, 2016

  • Added file header
  • Localized and escaped the text string
  • Applied best practices and coding standards
  • Added readme.txt
  • Added license file

Fixes #555

Tested & found working in WP 4.5

@GaryJones
Copy link
Member

I can't easily see the diff, so feel free to merge it yourself.

@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 2, 2016

I can't easily see the diff,

Yeah, I know, zip is not the best format for diffing, but it is the way it needs to be in the repo for the demo purpose for which it was included.

Would it be an idea to create a separate repo for maintaining the code of the example plugin ? That would make diffing a breeze when there would be updates (like this one).

so feel free to merge it yourself.

I'll give Thomas a chance to have a look at it first as it's in response to an issue he opened.

@GaryJones
Copy link
Member

A separate repo makes sense.

@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 2, 2016

A separate repo makes sense.

Created & given you both access. Initial commit is the original file, I've gone through the file history and found no other changes since.
Opened a PR TGMPA/tgm-example-plugin#2 for the changes contained in this PR.

@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 2, 2016

Oh and just for the record: I've not committed the OSX artefacts which were included in the original zip to the new repo and have removed these from the zip file in this PR as well.

- Added file header
- Localized and escaped the text string
- Applied best practices and coding standards
- Added readme.txt
- Added license file

Fixes #555
@jrfnl jrfnl force-pushed the feature/555-update-example-plugin branch from fc8a660 to 8bbc111 Compare April 10, 2016 18:34
@GaryJones GaryJones merged commit f642571 into develop Apr 19, 2016
@GaryJones GaryJones deleted the feature/555-update-example-plugin branch April 19, 2016 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants