Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaClass should offer getters for methods and constructors independent of the classpath #236

Closed
codecholeric opened this issue Sep 14, 2019 · 0 comments · Fixed by #246
Closed

JavaClass should offer getters for methods and constructors independent of the classpath #236

codecholeric opened this issue Sep 14, 2019 · 0 comments · Fixed by #246
Labels
enhancement good start to contributing help wanted

Comments

@codecholeric
Copy link
Collaborator

At the moment there are various options

javaClass.getCodeUnitWithParameterTypes(Class<?>...)
javaClass.getCodeUnitWithParameterTypeNames(String...)

but only

javaClass.getMethod(Class<?>...)
javaClass.getConstructor(Class<?>...)

It should be possible to retrieve methods and constructors, even if the parameter types are not in the classpath.
rweisleder added a commit to rweisleder/ArchUnit that referenced this issue Oct 7, 2019
@rweisleder
Overload JavaClass.getConstructor() and JavaClass.getMethod()
c90d8e5 
This commit adds the methods
  JavaClass.getConstructor(String... parameters)
  JavaClass.getMethod(String name, String... parameters)
  JavaClass.tryGetMethod(String name, String... parameters)
to retrieve constructors/methods even if a parameter type is not present
on the classpath.

The methods
  JavaClass.getConstructor()
  JavaClass.getMethod(String name)
  JavaClass.tryGetMethod(String name)
to retrieve constructors/methods without parameters where added to avoid
ambiguous method calls.

Resolves TNG#236

Signed-off-by: Roland Weisleder <[email protected]>
@rweisleder rweisleder mentioned this issue Oct 7, 2019
Merged
codecholeric pushed a commit to rweisleder/ArchUnit that referenced this issue Nov 3, 2019
@rweisleder @codecholeric
Overload JavaClass.getConstructor() and JavaClass.getMethod()
192c0a3 
This commit adds the methods
  JavaClass.getConstructor(String... parameters)
  JavaClass.getMethod(String name, String... parameters)
  JavaClass.tryGetMethod(String name, String... parameters)
to retrieve constructors/methods even if a parameter type is not present
on the classpath.

The methods
  JavaClass.getConstructor()
  JavaClass.getMethod(String name)
  JavaClass.tryGetMethod(String name)
to retrieve constructors/methods without parameters where added to avoid
ambiguous method calls.

Resolves TNG#236

Signed-off-by: Roland Weisleder <[email protected]>
codecholeric added a commit to rweisleder/ArchUnit that referenced this issue Nov 3, 2019
@codecholeric
Review: Improve test readability
1e2401c 
Issue: TNG#236
codecholeric added a commit that referenced this issue Nov 3, 2019
@codecholeric
Merge pull request #246 from rweisleder/gh-236
40625a3 
Overload JavaClass.getConstructor() and JavaClass.getMethod()
codecholeric pushed a commit that referenced this issue Feb 21, 2021
@rweisleder @codecholeric
Overload JavaClass.getConstructor() and JavaClass.getMethod()
3ad46b7 
This commit adds the methods
  JavaClass.getConstructor(String... parameters)
  JavaClass.getMethod(String name, String... parameters)
  JavaClass.tryGetMethod(String name, String... parameters)
to retrieve constructors/methods even if a parameter type is not present
on the classpath.

The methods
  JavaClass.getConstructor()
  JavaClass.getMethod(String name)
  JavaClass.tryGetMethod(String name)
to retrieve constructors/methods without parameters where added to avoid
ambiguous method calls.

Resolves #236

Signed-off-by: Roland Weisleder <[email protected]>
codecholeric added a commit that referenced this issue Feb 21, 2021
@codecholeric
Review: Improve test readability
e80c42e 
Issue: #236
codecholeric added a commit that referenced this issue Feb 21, 2021
@codecholeric
Merge pull request #246 from rweisleder/gh-236
018383a 
Overload JavaClass.getConstructor() and JavaClass.getMethod()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good start to contributing help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overload JavaClass.getConstructor() and JavaClass.getMethod() rweisleder/ArchUnit
1 participant
@codecholeric