Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to define Onion Architecture without Domain Services #271

Closed
pszymczyk opened this issue Nov 28, 2019 · 1 comment
Closed

Allow to define Onion Architecture without Domain Services #271

pszymczyk opened this issue Nov 28, 2019 · 1 comment

Comments

@pszymczyk
Copy link

Hi

I've just bump ArchUnit to 0.12.0 and one of my tests failed. It's because I have a module which has no Domain Services - only Application Services and Domain Model components. From my understanding this situation is totally ok and still consistent with all Onion Architecture principles, that's why in my opinion Domain Services layer should be an optional layer. What it's your point of view? If you agree I can proceed with Pull Request solving this issue.
@pszymczyk pszymczyk changed the title Allow to define Onion Architecture without domain services Allow to define Onion Architecture without Domain Services Nov 28, 2019
hankem added a commit that referenced this issue Dec 2, 2019
@hankem
allow for empty layers in OnionArchitecture (#271)
5c269c9 
Signed-off-by: Manfred Hanke <[email protected]>
@hankem hankem mentioned this issue Dec 2, 2019
Merged
codecholeric pushed a commit that referenced this issue Jan 9, 2020
@hankem @codecholeric
allow for empty layers in OnionArchitecture (#271)
9db4047 
Signed-off-by: Manfred Hanke <[email protected]>
codecholeric added a commit that referenced this issue Jan 9, 2020
@codecholeric
Allow empty layers in LayeredArchitecture & OnionArchitecture when co…
2e5668c 
…nfigured #273

Resolves #267 & #271:

After #177 had prevented empty layers by default, this can now be overridden to re-allow empty layers in `LayeredArchitecture` & `OnionArchitecture`.
@codecholeric
Copy link
Collaborator

Resolved by #273

codecholeric pushed a commit that referenced this issue Feb 21, 2021
@hankem @codecholeric
allow for empty layers in OnionArchitecture (#271)
445a979 
Signed-off-by: Manfred Hanke <[email protected]>
codecholeric added a commit that referenced this issue Feb 21, 2021
@codecholeric
Allow empty layers in LayeredArchitecture & OnionArchitecture when co…
1bd11d7 
…nfigured #273

Resolves #267 & #271:

After #177 had prevented empty layers by default, this can now be overridden to re-allow empty layers in `LayeredArchitecture` & `OnionArchitecture`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codecholeric @pszymczyk