Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archunit-junit5-api's @ArchTag is not composable #282

Closed
daniel-shuy opened this issue Dec 17, 2019 · 1 comment · Fixed by #287
Closed

archunit-junit5-api's @ArchTag is not composable #282

daniel-shuy opened this issue Dec 17, 2019 · 1 comment · Fixed by #287

Comments

@daniel-shuy
Copy link
Contributor

Unlike JUnit 5's @Tag, archunit-junit5-api's @ArchTag is not composable, eg.

@Inherited
@Documented
@Retention(RUNTIME)
@Target( {TYPE, METHOD, FIELD})
@ArchTag("my-tag")
public @interface MyAnnotation {
}

Would appreciate it if archunit-junit5-api could be enhanced to not only check for @ArchTag, but any annotation that composes it.

@codecholeric
Copy link
Collaborator

I guess it makes sense to be close to JUnit Jupiter considering the feature set, so if anybody wants to contribute this, I'd be happy to merge it! (I don't think it should be horribly complicated)
Otherwise I'll try to do it myself, but unfortunately my queue has a ton of other issues to fix before ☹️

daniel-shuy added a commit to daniel-shuy/ArchUnit that referenced this issue Dec 25, 2019
codecholeric pushed a commit to daniel-shuy/ArchUnit that referenced this issue Feb 4, 2020
daniel-shuy added a commit to daniel-shuy/ArchUnit that referenced this issue Feb 5, 2020
Resolves TNG#282

Signed-off-by: Daniel Shuy <[email protected]>
codecholeric pushed a commit that referenced this issue Feb 21, 2021
Resolves #282

Signed-off-by: Daniel Shuy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants