Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version of Gradle in wrapper task #308

Closed

Conversation

rweisleder
Copy link
Contributor

Belongs to #306 😉

The last upgrade of Gradle happened with ed02bda.

Signed-off-by: Roland Weisleder <[email protected]>
@ghost
Copy link

ghost commented Feb 7, 2020

DeepCode's analysis on #54e075 found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@codecholeric
Copy link
Collaborator

Thanks for paying attention 😄 I've completely removed the Gradle Wrapper task configuration in 802d90f though, because I think this is a leftover from old times.
When we upgrade the Gradle Wrapper, we'll do it like ./gradlew wrapper --gradle-version=5.6.4 anyway, and afterwards it's checked in, so I don't really see any use to configure this task with a default version at all.

@rweisleder rweisleder deleted the gradle-wrapper-version-property branch February 10, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants