Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable edition state optimization #164

Closed
PaulFarault opened this issue Feb 10, 2023 · 2 comments · Fixed by #191
Closed

Variable edition state optimization #164

PaulFarault opened this issue Feb 10, 2023 · 2 comments · Fixed by #191
Assignees
@PaulFarault
Labels
enhancement New feature or request

Comments

@PaulFarault
Copy link
Contributor

PaulFarault commented Feb 10, 2023 •
edited
Loading

The user input of the form are stored in Redux. It would be better to store them in a local context (as it was in the first place, but keeping the reducers introduced by Redux), and then send it to Redux once validated.

Also, we must ensure that the variables that have been modified and then the modification canceled, are not send to the server. (as described in #157 (comment)).
@PaulFarault PaulFarault added the enhancement New feature or request label Feb 10, 2023
This was referenced Feb 10, 2023
Merged
Merged
@PaulFarault
Copy link
Contributor Author

We may want to use React Hook Form for this one.

@PaulFarault PaulFarault self-assigned this Feb 15, 2023
@PaulFarault PaulFarault mentioned this issue Feb 17, 2023
Merged
2 tasks
@PaulFarault PaulFarault mentioned this issue Mar 3, 2023
Merged
2 tasks
PaulFarault added a commit that referenced this issue Mar 8, 2023
@PaulFarault
feat: share state between raw and view mode
c18eda5 
Add react-hook-form to optimize state.

Sync code editor in read mode (import values from view).

Persit user settings accross pages (raw mode, show unused tabs).

Fixes  #96
Fixes #164
TODO: sync code editor in write mode.
@PaulFarault
Copy link
Contributor Author

Unintentionally closed

@PaulFarault PaulFarault reopened this Mar 8, 2023
PaulFarault added a commit that referenced this issue Apr 12, 2023
@PaulFarault
feat: share state between raw and view mode
abf2ed0 
Add react-hook-form to optimize state.

Sync code editor in read mode (import values from view).

Persit user settings accross pages (raw mode, show unused tabs).

Fixes  #96
Fixes #164
TODO: sync code editor in write mode.
PaulFarault added a commit that referenced this issue Apr 12, 2023
@PaulFarault
feat: raw editor using monaco
8b45fa9 
Add react-hook-form to optimize state.

Sync raw and visual modes.

Persit user settings accross pages (raw mode, show unused tabs).

Fixes  #96
Fixes #164
sergkudinov pushed a commit to sergkudinov/tdp-ui that referenced this issue Apr 13, 2023
@PaulFarault @sergkudinov
feat: share state between raw and view mode
09978cb 
Add react-hook-form to optimize state.

Sync code editor in read mode (import values from view).

Persit user settings accross pages (raw mode, show unused tabs).

Fixes  TOSIT-IO#96
Fixes TOSIT-IO#164
TODO: sync code editor in write mode.
sergkudinov pushed a commit that referenced this issue Apr 17, 2023
@PaulFarault @sergkudinov
feat: share state between raw and view mode
f19d03c 
Add react-hook-form to optimize state.

Sync code editor in read mode (import values from view).

Persit user settings accross pages (raw mode, show unused tabs).

Fixes  #96
Fixes #164
TODO: sync code editor in write mode.
sergkudinov pushed a commit that referenced this issue Apr 18, 2023
@PaulFarault @sergkudinov
feat: share state between raw and view mode
cf167e8 
Add react-hook-form to optimize state.

Sync code editor in read mode (import values from view).

Persit user settings accross pages (raw mode, show unused tabs).

Fixes  #96
Fixes #164
TODO: sync code editor in write mode.
sergkudinov pushed a commit that referenced this issue Apr 26, 2023
@PaulFarault @sergkudinov
feat: share state between raw and view mode
d3003d7 
Add react-hook-form to optimize state.

Sync code editor in read mode (import values from view).

Persit user settings accross pages (raw mode, show unused tabs).

Fixes  #96
Fixes #164
TODO: sync code editor in write mode.
PaulFarault added a commit that referenced this issue May 10, 2023
@PaulFarault
feat: share state between raw and view mode
0921ca3 
Add react-hook-form to optimize state.

Sync code editor in read mode (import values from view).

Persit user settings accross pages (raw mode, show unused tabs).

Fixes  #96
Fixes #164
TODO: sync code editor in write mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulFarault PaulFarault

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@PaulFarault