Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tdp client #139

Merged
merged 5 commits into from
Jan 16, 2023
Merged

Feat/tdp client #139

merged 5 commits into from
Jan 16, 2023

Conversation

PaulFarault
Copy link
Contributor

@PaulFarault PaulFarault commented Jan 16, 2023

Which issue(s) this PR fixes

Fixes None

Additional comments

Remove axios from the list of dependencies to use fetch instead. Adjust the OpenAPI generator to use the typescript-fetch client. Migrate the authentication middle-ware from axios to fetch.

Also:

  • Centralize all @/tdp-client functions and types to be exported from the same place
  • Fix some vulnerable dependencies
  • Update tdp-server schema

TODO: save the user state in a global context to avoid having to read it from local storage at each request (to be done in #138 ).

Agreements

Copy link
Member

@gboutry gboutry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error 405 when trying to deploy with a dag

Worked when rebuilding the server image, there was a schema update

@PaulFarault PaulFarault merged commit 3bf5094 into master Jan 16, 2023
@PaulFarault PaulFarault deleted the feat/tdp-client branch January 16, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants