This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Removed drawer where not necessary #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we just populate the drawer properly in those views? It would make sense to have it so users can navigate faster. |
|
@kordianbruck It does not really make sense in those detail views, as the top left icon is a back button and not the drawer menu icon. It would not be intuitive that a drawer exists there. |
CommanderStorm
approved these changes
Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Empty drawer could be opened from certain views
This fixes the following issue(s):
#1433
Screenshot
(No more drawer from the left possible)
Why this is useful for all students
Bugfix