This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
removed "resolveActivity" check on open camera #1507
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR is a fix for a small bug I stumbled on. Since I found a solution rather quickly, I've skipped the creating an additional issue.
The problem was that the camera view in the feedback activity could not be opened.
Solution
This code (FeedbackPresenter) finished the method too early:
This check returns null even if successful in more recent API versions. This check is now removed and the potential exception will be caught if the activity does actually not exist.
How to test
Open Feedback tab and add a new image with the camera. Camera view should open.