Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

remove startActivityForResult on FeedbackActivity for camera and gallery #1523

Conversation

cchigo
Copy link
Contributor

@cchigo cchigo commented Oct 26, 2022

Issue

This fixes the following issue(s):

Screenshot

Why this is useful for all students

@cchigo
Copy link
Contributor Author

cchigo commented Oct 26, 2022

@CommanderStorm Good day, please review

Copy link
Member

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I could deduce, without having run it.
Looks good to me, but bevore approving I am going to run that code.
I am probably going to get to that tonight. If not I am sorry

Copy link
Contributor

@tobiasjungmann tobiasjungmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work on my test devices. Great to remove the outdated methods!

@kordianbruck kordianbruck enabled auto-merge (squash) November 4, 2022 10:14
@kordianbruck
Copy link
Member

Thanks for testing Tobias and thanks @cchigo for contributing!

@kordianbruck
Copy link
Member

There are a few more lint warnings that you might be able to address by using the "auto format" feature in android studio:

/home/runner/work/Campus-Android/Campus-Android/app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt:39:1: Needless blank line(s)
/home/runner/work/Campus-Android/Campus-Android/app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt:50:85: Missing spacing before "{"
/home/runner/work/Campus-Android/Campus-Android/app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt:54:86: Missing spacing around "{"
/home/runner/work/Campus-Android/Campus-Android/app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt:59:1: Needless blank line(s)
/home/runner/work/Campus-Android/Campus-Android/app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt:149:47: Missing spacing before "{"
/home/runner/work/Campus-Android/Campus-Android/app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt:157:10: Missing spacing after "}"
/home/runner/work/Campus-Android/Campus-Android/app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt:157:46: Missing spacing before "{"
/home/runner/work/Campus-Android/Campus-Android/app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt:160:1: Unexpected blank line(s) before "}"

Copy link
Member

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First bunch of formatting fixes

@CommanderStorm CommanderStorm force-pushed the feat_remove_deprecated_startActivityForResult branch from 44c677c to fe6d0d3 Compare November 14, 2022 19:04
@CommanderStorm CommanderStorm force-pushed the feat_remove_deprecated_startActivityForResult branch from fe6d0d3 to 283bc5e Compare November 14, 2022 19:05
@kordianbruck kordianbruck merged commit 0b3b68b into TUM-Dev:master Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

startActivityForResult is Deprecated
4 participants