-
-
Notifications
You must be signed in to change notification settings - Fork 86
remove startActivityForResult on FeedbackActivity for camera and gallery #1523
remove startActivityForResult on FeedbackActivity for camera and gallery #1523
Conversation
@CommanderStorm Good day, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I could deduce, without having run it.
Looks good to me, but bevore approving I am going to run that code.
I am probably going to get to that tonight. If not I am sorry
app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work on my test devices. Great to remove the outdated methods!
Thanks for testing Tobias and thanks @cchigo for contributing! |
There are a few more lint warnings that you might be able to address by using the "auto format" feature in android studio:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First bunch of formatting fixes
app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/tum/in/tumcampusapp/component/tumui/feedback/FeedbackActivity.kt
Outdated
Show resolved
Hide resolved
44c677c
to
fe6d0d3
Compare
…ack/FeedbackActivity.kt Co-authored-by: Frank Elsinga <[email protected]>
…ack/FeedbackActivity.kt Co-authored-by: Frank Elsinga <[email protected]>
…ack/FeedbackActivity.kt Co-authored-by: Frank Elsinga <[email protected]>
fe6d0d3
to
283bc5e
Compare
Issue
This fixes the following issue(s):
startActivityForResult
is Deprecated #1486Screenshot
Why this is useful for all students