Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK:T12] Migrate top.fsMod.recentIds for BE modules #3489

Closed
Tracked by #3376
dkd-kaehm opened this issue Feb 10, 2023 · 2 comments · Fixed by #3794
Closed
Tracked by #3376

[TASK:T12] Migrate top.fsMod.recentIds for BE modules #3489

dkd-kaehm opened this issue Feb 10, 2023 · 2 comments · Fixed by #3794
Assignees
@dkd-friedrich
Milestone
12.0 aka TYPO3 12...

Comments

@dkd-kaehm
Copy link
Collaborator

dkd-kaehm commented Feb 10, 2023 •
edited
Loading

In TYPO3 12 are ModuleTemplate::addJavaScriptCode() and top.fsMod.recentIds not available anymore.

The code is currently commented, this must be migrated or removed:

ext-solr/Classes/Controller/Backend/Search/AbstractModuleController.php

Lines 225 to 229 in cbc7af1

$this->moduleTemplate->addJavaScriptCode(
'mainJsFunctions',
'
top.fsMod.recentIds["searchbackend"] = ' . $this->selectedPageUID . ';'
);

See:
@dkd-kaehm dkd-kaehm mentioned this issue Feb 10, 2023
Closed
68 tasks
@dkd-kaehm dkd-kaehm changed the title [TASK] Migrate top.fsMod.recentIds for BE modules [TASK:T12] Migrate top.fsMod.recentIds for BE modules Feb 10, 2023
@instruccionesaldorso
Copy link

@dkd-kaehm Could this be applied to version 11.5.x from the extension as well, as it is deprecated in v11 and throwns errors in the console when using the Solr BE modules?

@dkd-kaehm
Copy link
Collaborator Author

dkd-kaehm commented May 25, 2023 •
edited
Loading

@dkd-kaehm Could this be applied to version 11.5.x from the extension as well, as it is deprecated in v11 and throwns errors in the console when using the Solr BE modules?

If the backport is cherry-pickable,
we can do that.
Could you please watch/observe and ping us again if the patch is available?

@dkd-friedrich dkd-friedrich self-assigned this Sep 20, 2023
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Sep 21, 2023
@dkd-friedrich
[TASK] Migrate top.fsMod
719d5cc 
JavaScript top.fsMod is deprecated since TYPO3 11.4, this commit
replaces the old top.fsMod usage with the ModuleStateStorage,
now the ImmediateActionElement is used.

Resolves: TYPO3-Solr#3489
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Sep 21, 2023
@dkd-friedrich
[TASK] Replace RequireJS
91e9306 
RequireJS integration is deprecated in TYPO3 12 and will be removed
with TYPO3 13, thus search statistics JavaScript is adapted for
ECMAScript v6.

An update to Chart.js 3.9.1 is also done, which provides ES6 support.
Integration in Chart.js 4 is currently faulty and is postponed.

Resolves: TYPO3-Solr#3489
@dkd-friedrich dkd-friedrich mentioned this issue Sep 21, 2023
Merged
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Sep 21, 2023
@dkd-friedrich
[TASK] Migrate top.fsMod
7c20c1b 
JavaScript top.fsMod is deprecated since TYPO3 11.4, this commit
replaces the old top.fsMod usage with the ModuleStateStorage,
now the ImmediateActionElement is used.

Ports: TYPO3-Solr#3794
Resolves: TYPO3-Solr#3489
@dkd-friedrich dkd-friedrich mentioned this issue Sep 21, 2023
Merged
dkd-friedrich added a commit to dkd-friedrich/ext-solr that referenced this issue Sep 21, 2023
@dkd-friedrich
[TASK] Replace RequireJS
3533d32 
RequireJS integration is deprecated in TYPO3 12 and will be removed
with TYPO3 13, thus search statistics JavaScript is adapted for
ECMAScript v6.

An update to Chart.js 3.9.1 is also done, which provides ES6 support.
Integration in Chart.js 4 is currently faulty and is postponed.

Resolves: TYPO3-Solr#3489
dkd-friedrich added a commit that referenced this issue Sep 21, 2023
@dkd-friedrich
[TASK] Migrate top.fsMod
3da50d4 
JavaScript top.fsMod is deprecated since TYPO3 11.4, this commit
replaces the old top.fsMod usage with the ModuleStateStorage,
now the ImmediateActionElement is used.

Resolves: #3489
dkd-friedrich added a commit that referenced this issue Sep 21, 2023
@dkd-friedrich
[TASK] Replace RequireJS
fcf82f6 
RequireJS integration is deprecated in TYPO3 12 and will be removed
with TYPO3 13, thus search statistics JavaScript is adapted for
ECMAScript v6.

An update to Chart.js 3.9.1 is also done, which provides ES6 support.
Integration in Chart.js 4 is currently faulty and is postponed.

Resolves: #3489
dkd-friedrich added a commit that referenced this issue Sep 21, 2023
@dkd-friedrich
[TASK] Migrate top.fsMod
542dd42 
JavaScript top.fsMod is deprecated since TYPO3 11.4, this commit
replaces the old top.fsMod usage with the ModuleStateStorage,
now the ImmediateActionElement is used.

Ports: #3794
Resolves: #3489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkd-friedrich dkd-friedrich

Labels
None yet
Projects
TYPO3 12 LTS compatibility
Status: Done
Milestone
12.0 aka TYPO3 12 LTS - major release
Development

Successfully merging a pull request may close this issue.

[TASK] Migrate javascript modules dkd-friedrich/ext-solr
3 participants
@dkd-friedrich @instruccionesaldorso @dkd-kaehm