Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] PHP 8: Reduce PHP related warnings #3535

Closed
3l73 opened this issue Mar 6, 2023 · 0 comments · Fixed by #3536
Closed

[TASK] PHP 8: Reduce PHP related warnings #3535

3l73 opened this issue Mar 6, 2023 · 0 comments · Fixed by #3536
Assignees
@3l73

Comments

@3l73
Copy link
Collaborator

3l73 commented Mar 6, 2023

What should be done in the scope of this task?

On TYPO3 installations using PHP 8 the extensions produce warnings in case the accessed variables are not defined or did not match the expected type.

In order to reduce the log messages the following code lines should be adjusted:

Core: Error handler (BE): PHP Warning: Trying to access array offset on value of type null in public/typo3conf/ext/solr/Classes/Domain/Index/Queue/RecordMonitor/Helper/RootPageResolver.php line 243

PHP Warning: Undefined array key "<someKey>" in public/typo3conf/ext/solr/Classes/IndexQueue/AbstractIndexer.php line 190
@3l73 3l73 self-assigned this Mar 6, 2023
3l73 added a commit to 3l73/ext-solr that referenced this issue Mar 6, 2023
@3l73
[TASK] Verify the record before accessing the pid
15d72a3 
Verify that the record is not null before access the page id.

Resolves: TYPO3-Solr#3535
3l73 added a commit to 3l73/ext-solr that referenced this issue Mar 6, 2023
@3l73
[TASK] Verify that the array key exists
1b4e630 
PHP 8 seems to have an issue with the short syntax in case the array is accessed with a variable.

Resolves: TYPO3-Solr#3535
@3l73 3l73 mentioned this issue Mar 6, 2023
Merged
3l73 added a commit to 3l73/ext-solr that referenced this issue Mar 7, 2023
@3l73
[TASK] Verify the record before accessing the pid
59f4dcc 
Verify that the record is not null before access the page id.

Resolves: TYPO3-Solr#3535
@3l73 3l73 mentioned this issue Mar 7, 2023
Merged
dkd-friedrich pushed a commit that referenced this issue Mar 7, 2023
@3l73 @dkd-friedrich
[TASK] Verify the record before accessing the pid
5655891 
Verify that the record is not null before access the page id.

Resolves: #3535
dkd-friedrich pushed a commit that referenced this issue Mar 7, 2023
@3l73 @dkd-friedrich
[TASK] Verify the record before accessing the pid
39fc073 
Verify that the record is not null before access the page id.

Resolves: #3535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3l73 3l73

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TASK] Verify the record before accessing the pid 3l73/ext-solr
1 participant
@3l73