-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] 12.0.0-beta-1 : indexPage and incorrect fe_groups on access protected instance #3735
Closed
Tracked by
#3376
Comments
Apen
changed the title
[BUG] 12.0.0-beta-1 : indexPage and incorrect fe_groups
[BUG] 12.0.0-beta-1 : indexPage and incorrect fe_groups on access protected instance
Jul 26, 2023
Related change set: |
68 tasks
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this issue
Oct 6, 2023
Fixes indexing of access protected pages and/or page contents. Resolves: TYPO3-Solr#3735
dkd-friedrich
added a commit
to dkd-friedrich/ext-solr
that referenced
this issue
Oct 6, 2023
Cleans and optimizes the frontend helper "PageIndexer" integration test. Failure test for non existing pages/sites is refactored and PageIndexer adapted, even if AfterCacheableContentIsGeneratedEvent is not dispatched e.g. as the page is not found, the response will always contain the pageIndexed flag. Additionally the methods of PageIndexer that were defined as public to simplify testing are now protected, the tests are adapted accordingly. If you have used this methods, you have to adapt your code. Affected methods: - setupConfiguration - index - indexPage Relates: TYPO3-Solr#3735
dkd-kaehm
pushed a commit
to dkd-friedrich/ext-solr
that referenced
this issue
Oct 10, 2023
Fixes indexing of access protected pages and/or page contents. Resolves: TYPO3-Solr#3735
dkd-kaehm
pushed a commit
to dkd-friedrich/ext-solr
that referenced
this issue
Oct 10, 2023
Cleans and optimizes the frontend helper "PageIndexer" integration test. Failure test for non existing pages/sites is refactored and PageIndexer adapted, even if AfterCacheableContentIsGeneratedEvent is not dispatched e.g. as the page is not found, the response will always contain the pageIndexed flag. Additionally the methods of PageIndexer that were defined as public to simplify testing are now protected, the tests are adapted accordingly. If you have used this methods, you have to adapt your code. Affected methods: - setupConfiguration - index - indexPage Relates: TYPO3-Solr#3735
dkd-kaehm
pushed a commit
that referenced
this issue
Oct 10, 2023
Fixes indexing of access protected pages and/or page contents. Resolves: #3735
dkd-kaehm
pushed a commit
that referenced
this issue
Oct 10, 2023
Cleans and optimizes the frontend helper "PageIndexer" integration test. Failure test for non existing pages/sites is refactored and PageIndexer adapted, even if AfterCacheableContentIsGeneratedEvent is not dispatched e.g. as the page is not found, the response will always contain the pageIndexed flag. Additionally the methods of PageIndexer that were defined as public to simplify testing are now protected, the tests are adapted accordingly. If you have used this methods, you have to adapt your code. Affected methods: - setupConfiguration - index - indexPage Relates: #3735
dkd-friedrich
added a commit
that referenced
this issue
Oct 13, 2023
Fixes the handling of root pages, slug "/", in SolrRoutingMiddleware. On root pages the manipulated request uri contained duplicate slashes that might cause issues, e.g. with InternalRequests in the integration tests. Relates: #3735
dkd-kaehm
pushed a commit
that referenced
this issue
Oct 13, 2023
Fixes the handling of root pages, slug "/", in SolrRoutingMiddleware. On root pages the manipulated request uri contained duplicate slashes that might cause issues, e.g. with InternalRequests in the integration tests. Relates: #3735
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this issue
Oct 13, 2023
This change is the follow-up of TYPO3-Solr@a6168bcc6 Relates: TYPO3-Solr#3735, TYPO3-Solr#3811
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this issue
Oct 13, 2023
This change is the follow-up of TYPO3-Solr@a6168bcc6 Relates: TYPO3-Solr#3735, TYPO3-Solr#3811
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this issue
Oct 13, 2023
This change is the follow-up of TYPO3-Solr@a6168bcc6 Relates: TYPO3-Solr#3735, TYPO3-Solr#3811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The new version 12.0.0-beta-1 on last TYPO3 v12 doesnt get the correct fe_groups on frontend indexation. After a long debug session i notice a bug with 'solr.pageIndexingInstructions' & FrontendGroupsModifier .
This is a side effect of the Middleware order and the new attriibute 'solr.pageIndexingInstructions'.
TYPO3\CMS\Frontend\Middleware\FrontendUserAuthenticator
is processed beforeApacheSolrForTypo3\Solr\Middleware\PageIndexerInitialization
.So in
\ApacheSolrForTypo3\Solr\EventListener\PageIndexer\FrontendGroupsModifier
we will never have 'solr.pageIndexingInstructions' and we doesnt populate the correct fe_groups on a protected instance. So all the pages wil never be indexer and we only have the generic error message during indexing.A smal test to validate that in
FrontendGroupsModifier
;I force the
$pageIndexerRequest
to be regenerated, and all is working now :-)This is not the correct solution, it is simply validate the bug.
Maybe fire the middleware before "typo3/cms-frontend/authentication" is the solution?
I let you choose that.
The text was updated successfully, but these errors were encountered: