Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] undefined array key in sort arguments logic #3874

Closed
schugabe opened this issue Nov 14, 2023 · 0 comments · Fixed by #3876
Closed

[BUG] undefined array key in sort arguments logic #3874

schugabe opened this issue Nov 14, 2023 · 0 comments · Fixed by #3876

Comments

@schugabe
Copy link
Contributor

Describe the bug
We get many search requests from bots in the form of ?tx_solr%5Bfilter%5D&tx_solr%5Bpage%5D=1&tx_solr%5Bq%5D=quality&tx_solr%5Bsort%5D=title%2Basc

That triggers a warning: Undefined array key 1 in Classes/Domain/Search/SearchRequest.php line 353.

In the method getSeperatedSortings the result from the explode call is used without length check.

Used versions (please complete the following information):

  • TYPO3 Version: 11.5.32
  • EXT:solr Version: 11.5.4

Additional context
Looks like the same issue is present in ext:solr version 12.
schugabe added a commit to schugabe/ext-solr that referenced this issue Nov 14, 2023
@schugabe
[BUGFIX] check if all sorting parts are present before access
96eefbc 
fixes TYPO3-Solr#3874
@schugabe schugabe mentioned this issue Nov 14, 2023
Closed
schugabe added a commit to schugabe/ext-solr that referenced this issue Nov 14, 2023
@schugabe
[BUGFIX] check if all sorting parts are present before access
e4e4e1a 
fixes TYPO3-Solr#3874
@schugabe schugabe mentioned this issue Nov 14, 2023
Merged
dkd-kaehm pushed a commit to dkd-kaehm/ext-solr that referenced this issue Nov 15, 2023
@schugabe @dkd-kaehm
[BUGFIX] check if all sorting parts are present before access
73681ca 
Fixes: TYPO3-Solr#3874
Ports: TYPO3-Solr#3876
Replaces: TYPO3-Solr#3875
@dkd-kaehm dkd-kaehm mentioned this issue Nov 15, 2023
Merged
dkd-kaehm pushed a commit that referenced this issue Nov 15, 2023
@schugabe @dkd-kaehm
[BUGFIX] check if all sorting parts are present before access
d54a476 
Fixes: #3874
Ports: #3876
Replaces: #3875
dkd-kaehm pushed a commit that referenced this issue Nov 15, 2023
@schugabe @dkd-kaehm
[BUGFIX] check if all sorting parts are present before access
e5826f3 
fixes #3874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] check if all sorting parts are present before access schugabe/ext-solr
1 participant
@schugabe