Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] sub page of restricted page with "Extend to Subpages" is not indexed #3969

Closed
deschilter opened this issue Feb 27, 2024 · 3 comments · Fixed by #3982
Closed

[BUG] sub page of restricted page with "Extend to Subpages" is not indexed #3969

deschilter opened this issue Feb 27, 2024 · 3 comments · Fixed by #3982

Comments

@deschilter
Copy link

Describe the bug
When a page is restricted to an fe_group by restricting the parent page and activating the "Extend to Subpages", it won't be indexed.
The indexing request will result in a 404 and the frontendHelper is never called.

This is because no or pageUserGroup is passed in the request.
It is only passed if the current page is restricted: PageIndexer.php#L297
In that case the FrontendGroupsModifier would grant access to the page, but without a userGroup or a pageUserGroup, it won't.

To Reproduce
Steps to reproduce the behavior:

  1. Create a page called parent and restrict it to any fe_group
  2. Check Extend to Subpages for the page parent
  3. Create a subpage for the page parent called child
  4. Index the pages

Expected behavior
Both pages, parent and child, should be correctly indexed.
Currently only the parent is indexed and the child results in an error.

Used versions (please complete the following information):

  • TYPO3 Version: 12.4.11
  • EXT:solr Version: 12.0.2
  • Used Apache Solr Version: typo3solr/ext-solr:latest
  • PHP Version: 8.1.26
@deschilter
Copy link
Author

It seems this was introduced by this change and should therefore only affect v12

@dkd-kaehm
Copy link
Collaborator

It seems this was introduced by this change and should therefore only affect v12

@deschilter There are 13 files changed, which part of change exactly?

Is #3926 related? Could you try if that fixes the issue?

deschilter pushed a commit to deschilter/ext-solr that referenced this issue Feb 27, 2024
@deschilter
Copy link
Author

The part which checks if the FrontendGroupsModifier should be applied.
a6168bc#diff-bf28763c35325e20091cdc41e71675d16a1f04fb2dbf94f7adb0b1d0f61abaf0R44

I tested #3926 and it does not solve this issue.

deschilter pushed a commit to deschilter/ext-solr that referenced this issue Mar 12, 2024
deschilter pushed a commit to deschilter/ext-solr that referenced this issue Mar 13, 2024
deschilter pushed a commit to deschilter/ext-solr that referenced this issue Mar 26, 2024
dkd-kaehm pushed a commit to deschilter/ext-solr that referenced this issue Apr 5, 2024
dkd-kaehm pushed a commit to deschilter/ext-solr that referenced this issue Apr 5, 2024
dkd-kaehm pushed a commit to deschilter/ext-solr that referenced this issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants