Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Make API eID script compatible with TYPO3 v11.5 #3350

Merged
merged 1 commit into from
Oct 21, 2022
Merged

[BUGFIX] Make API eID script compatible with TYPO3 v11.5 #3350

merged 1 commit into from
Oct 21, 2022

Conversation

peterkraume
Copy link
Contributor

What this pr does

With TYPO3 v11.5 the API to create a siteHash doesn't work anymore:

Uncaught TYPO3 Exception: #1425381442: Invalid target for "EXT:solr/Classes/Eid/Api.php", as it is not callable. | InvalidArgumentException thrown in file /typo3/sysext/core/Classes/Http/Dispatcher.php in line 95. Requested URL: https://www.domain.tld/index.php?eID=tx_solr_api&api=siteHash&domain=otherdomain.tld&apiKey=98edf0f46e468fbc35d21b9215e73cd8c8017a6c

How to test

Call to https://www.domain.tld/index.php?eID=tx_solr_api&api=siteHash&domain=otherdomain.tld&apiKey=98edf0f46e468fbc35d21b9215e73cd8c8017a6c
should return a valid json encoded response like this:

{"sitehash":"d25b497e596326aeba48edac11294668d793481f"}

dkd-kaehm
dkd-kaehm requested changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor Classes/Eid/SiteHash.php to the class and method as well.

@peterkraume
Copy link
Contributor Author

What would the benefit of refactoring Classes/Eid/SiteHash.php to a class be? Currently it's just included in Classes/Eid/ApiEid.php. If someone uses SiteHash.php it'll break if I refactor it. I would rather suggest include the code from the file within case 'siteHash': instead of creating a new class.

@dkd-kaehm
Copy link
Collaborator

What would the benefit of refactoring Classes/Eid/SiteHash.php to a class be? Currently it's just included in Classes/Eid/ApiEid.php. If someone uses SiteHash.php it'll break if I refactor it. I would rather suggest include the code from the file within case 'siteHash': instead of creating a new class.

I'll switch the target branch to release-11.5.x for this PR without BC,
the port for main branch must contain the refactoring on that file.

@dkd-kaehm dkd-kaehm changed the base branch from main to release-11.5.x September 23, 2022 09:36
@dkd-kaehm dkd-kaehm mentioned this pull request Oct 21, 2022
Closed
44 tasks
dkd-kaehm pushed a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 21, 2022
@peterkraume @dkd-kaehm
[BUGFIX] Make API eID script compatible with TYPO3 v11.5
566c54e 
Ports: TYPO3-Solr#3350
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 21, 2022
@dkd-kaehm
[TASK] Refactor API eID script
035bdc9 
Relates: TYPO3-Solr#3350
dkd-kaehm pushed a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 21, 2022
@peterkraume @dkd-kaehm
[BUGFIX] Make API eID script compatible with TYPO3 v11.5
94aa488 
Ports: TYPO3-Solr#3350
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Oct 21, 2022
@dkd-kaehm
[TASK] Refactor API eID script
fcaafc7 
Relates: TYPO3-Solr#3350
@dkd-kaehm dkd-kaehm mentioned this pull request Oct 21, 2022
Merged
dkd-kaehm pushed a commit that referenced this pull request Oct 21, 2022
@peterkraume @dkd-kaehm
[BUGFIX] Make API eID script compatible with TYPO3 v11.5
87b05a6 
Ports: #3350
dkd-kaehm added a commit that referenced this pull request Oct 21, 2022
@dkd-kaehm
[TASK] Refactor API eID script
4771984 
Relates: #3350
@dkd-kaehm dkd-kaehm merged commit c29dcec into TYPO3-Solr:release-11.5.x Oct 21, 2022
@dkd-kaehm dkd-kaehm mentioned this pull request Dec 22, 2022
Closed
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 22, 2022
@dkd-kaehm
[RELEASE] 11.5.1 - Maintenance Release
343c6cd 
This is a maintenance release for TYPO3 11.5, containing:

- [BUGFIX] Do not include removed strptime() (TYPO3-Solr#3335)
- [BUGFIX:BP:11.5] Do not handle page updates on new page with uid 0 (TYPO3-Solr#3344)
- [BUGFIX:BP:11.5] Shortcircuit work in SolrRoutingMiddleware (TYPO3-Solr#3341)
- !!![TASK] Use preAddModifyDocuments  hook for pages (TYPO3-Solr#3076)
- [BUGFIX] Fix array key access in ext_getSetup (Backport 11.5) (TYPO3-Solr#3361)
- [TASK:BP:11.5] Indexing configuration icon fallback (TYPO3-Solr#3371)
- [BUGFIX:BP:11.5] Do not index missing fields (TYPO3-Solr#3372)
- [TASK:BP:11.5] Introduce index queue type setting (TYPO3-Solr#3370)
- [TASK:BP:11.5] Do not index language with unconfigured core (TYPO3-Solr#3373)
- [BUGFIX] Make API eID script compatible with TYPO3 v11.5 (TYPO3-Solr#3350)
- [BUGFIX] Type-hinting for SiteUtility::getConnectionProperty() (TYPO3-Solr#3396)
- [TASK:BP:11.5] Introduce generic EXT:solr exception (TYPO3-Solr#3422)
- [BUGFIX:BP:11.5] Fix frontend Solr connection initialization (TYPO3-Solr#3425)
- [ACTIONS:2022.12.22] Use fixed typo3/coding-standards 0.6.x < 0.7.0 for TYPO3 11.5 (TYPO3-Solr#3429)
- [TASK:Security] Update jQuery and its plugin libs (TYPO3-Solr#3428)
- [BUGFIX:P:11.5] Proper check for config.index_enable (TYPO3-Solr#3433)
- [BUGFIX:P:11.5] Typecast $timestamp to int in TimestampToUtcIsoDate (TYPO3-Solr#3434)
- [BUGFIX:P:11.5] prevent undefined array key warning if filter is empty (TYPO3-Solr#3435)
- [FEATURE] Add signal before search in resultsAction (TYPO3-Solr#3392)
- [BUGFIX] Fix php warning undefined array key no_search_sub_entries (TYPO3-Solr#3381)

Please read the release notes:
https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.1

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
  existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
  development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
@dkd-kaehm dkd-kaehm mentioned this pull request Dec 22, 2022
Merged
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 22, 2022
@dkd-kaehm
[RELEASE] 11.5.1 - Maintenance Release
76c75d4 
This is a maintenance release for TYPO3 11.5, containing:

- [BUGFIX] Do not include removed strptime() (TYPO3-Solr#3335)
- [BUGFIX:BP:11.5] Do not handle page updates on new page with uid 0 (TYPO3-Solr#3344)
- [BUGFIX:BP:11.5] Shortcircuit work in SolrRoutingMiddleware (TYPO3-Solr#3341)
- !!![TASK] Use preAddModifyDocuments  hook for pages (TYPO3-Solr#3076)
- [BUGFIX] Fix array key access in ext_getSetup (Backport 11.5) (TYPO3-Solr#3361)
- [TASK:BP:11.5] Indexing configuration icon fallback (TYPO3-Solr#3371)
- [BUGFIX:BP:11.5] Do not index missing fields (TYPO3-Solr#3372)
- [TASK:BP:11.5] Introduce index queue type setting (TYPO3-Solr#3370)
- [TASK:BP:11.5] Do not index language with unconfigured core (TYPO3-Solr#3373)
- [BUGFIX] Make API eID script compatible with TYPO3 v11.5 (TYPO3-Solr#3350)
- [BUGFIX] Type-hinting for SiteUtility::getConnectionProperty() (TYPO3-Solr#3396)
- [TASK:BP:11.5] Introduce generic EXT:solr exception (TYPO3-Solr#3422)
- [BUGFIX:BP:11.5] Fix frontend Solr connection initialization (TYPO3-Solr#3425)
- [ACTIONS:2022.12.22] Use fixed typo3/coding-standards 0.6.x < 0.7.0 for TYPO3 11.5 (TYPO3-Solr#3429)
- [TASK:Security] Update jQuery and its plugin libs (TYPO3-Solr#3428)
- [BUGFIX:P:11.5] Proper check for config.index_enable (TYPO3-Solr#3433)
- [BUGFIX:P:11.5] Typecast $timestamp to int in TimestampToUtcIsoDate (TYPO3-Solr#3434)
- [BUGFIX:P:11.5] prevent undefined array key warning if filter is empty (TYPO3-Solr#3435)
- [FEATURE] Add signal before search in resultsAction (TYPO3-Solr#3392)
- [BUGFIX] Fix php warning undefined array key no_search_sub_entries (TYPO3-Solr#3381)

Please read the release notes:
https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.1

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
  existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
  development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
dkd-kaehm added a commit that referenced this pull request Dec 23, 2022
@dkd-kaehm
[RELEASE] 11.5.1 - Maintenance Release
d095058 
This is a maintenance release for TYPO3 11.5, containing:

- [BUGFIX] Do not include removed strptime() (#3335)
- [BUGFIX:BP:11.5] Do not handle page updates on new page with uid 0 (#3344)
- [BUGFIX:BP:11.5] Shortcircuit work in SolrRoutingMiddleware (#3341)
- !!![TASK] Use preAddModifyDocuments  hook for pages (#3076)
- [BUGFIX] Fix array key access in ext_getSetup (Backport 11.5) (#3361)
- [TASK:BP:11.5] Indexing configuration icon fallback (#3371)
- [BUGFIX:BP:11.5] Do not index missing fields (#3372)
- [TASK:BP:11.5] Introduce index queue type setting (#3370)
- [TASK:BP:11.5] Do not index language with unconfigured core (#3373)
- [BUGFIX] Make API eID script compatible with TYPO3 v11.5 (#3350)
- [BUGFIX] Type-hinting for SiteUtility::getConnectionProperty() (#3396)
- [TASK:BP:11.5] Introduce generic EXT:solr exception (#3422)
- [BUGFIX:BP:11.5] Fix frontend Solr connection initialization (#3425)
- [ACTIONS:2022.12.22] Use fixed typo3/coding-standards 0.6.x < 0.7.0 for TYPO3 11.5 (#3429)
- [TASK:Security] Update jQuery and its plugin libs (#3428)
- [BUGFIX:P:11.5] Proper check for config.index_enable (#3433)
- [BUGFIX:P:11.5] Typecast $timestamp to int in TimestampToUtcIsoDate (#3434)
- [BUGFIX:P:11.5] prevent undefined array key warning if filter is empty (#3435)
- [FEATURE] Add signal before search in resultsAction (#3392)
- [BUGFIX] Fix php warning undefined array key no_search_sub_entries (#3381)

Please read the release notes:
https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.1

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
  existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
  development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
@dkd-friedrich dkd-friedrich mentioned this pull request Mar 24, 2023
Merged
dkd-friedrich pushed a commit to dkd-friedrich/ext-solr that referenced this pull request Mar 24, 2023
@peterkraume @dkd-friedrich
[BUGFIX:BP:11.2] Make API eID script compatible with TYPO3 v11.5
05214a0 
Ports: TYPO3-Solr#3350
dkd-friedrich pushed a commit to dkd-friedrich/ext-solr that referenced this pull request Mar 24, 2023
@peterkraume @dkd-friedrich
[BUGFIX:BP:11.2] Make API eID script compatible with TYPO3 v11.5
b7ec160 
Ports: TYPO3-Solr#3350
dkd-friedrich pushed a commit that referenced this pull request Mar 27, 2023
@peterkraume @dkd-friedrich
[BUGFIX:BP:11.2] Make API eID script compatible with TYPO3 v11.5
708df0f 
Ports: #3350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkd-kaehm dkd-kaehm dkd-kaehm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
EXT:solr 11.5+ TYPO3 11+12+
Development

Successfully merging this pull request may close these issues.
2 participants
@peterkraume @dkd-kaehm