[BUGFIX] add empty string as fallback #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reporting and providing a patch. Ensuring that a decoded string is returned is unfortunately not sufficient. An invalid filter will be applied and Solr will return an error ( I've added a check for invalid filter parts, invalid filters will be ignored and logged. |
ensure a string is always returned, even if the query does not exist
Invalid filter options will lead to Solr errors and exceptions in frontend. This commit adds an additional check, ensuring invalid filter options will not be applied. A log entry will help the website administrator to solve the issue.
dkd-friedrich
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
ensure a string is always returned, even if the query does not exist
How to test
Define a queryGroup "A", filter by that new group, manipulate the url by hand, submit form. Page should not show error.