[BUGFIX] Ensure record exists before asserting if draft #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix is maybe not the good one, as it can hide the real issue: why the record was not found? |
Did you find out why it was so on your system? |
|
I just added some information how to reproduce it in #3531: It happens if a record is deleted. |
|
I'm also not exactly sure why an already deleted record gets processed by the RecordMonitor or the GarbageCollector, but as draft records will be ignored anyway it should be safe to fix this issue that way. |
|
@dogawaf Thanks for providing a pr, I'll do a backport to 11.5. |
dkd-friedrich
pushed a commit
to dkd-friedrich/ext-solr
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
This fix an error in case a record was not found in the garbage collector process.
Fixes: #3531