Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Avoid PHP 8 warning when page indexing fails #3606

Merged

Conversation

koehnlein
Copy link
Contributor

What this pr does

Set variable $this->responseData['pageIndexed'] = false try/catch to make it available for further processing

How to test

See detailed information in related issue

Fixes: #3605

@koehnlein koehnlein changed the base branch from main to release-11.5.x April 14, 2023 18:13
@koehnlein koehnlein changed the base branch from release-11.5.x to main April 14, 2023 18:18
@koehnlein koehnlein changed the title Feature/index fail warnings [BUGFIX] Avoid PHP 8 warning when page indexing fails Apr 14, 2023
Copy link
Member

@dkd-friedrich dkd-friedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkd-friedrich
Copy link
Member

@koehnlein Thanks for reporting and providing a PR

I'll take care of a backport to 11.5

dkd-friedrich pushed a commit to dkd-friedrich/ext-solr that referenced this pull request Apr 17, 2023
@dkd-friedrich dkd-friedrich merged commit e36571b into TYPO3-Solr:main Apr 17, 2023
@dkd-kaehm dkd-kaehm mentioned this pull request Oct 13, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PHP 8 warnings when indexing a page fails
2 participants