Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fixes multiple sortings #3628

Merged
merged 1 commit into from
Oct 12, 2023
Merged

[BUGFIX] Fixes multiple sortings #3628

merged 1 commit into from
Oct 12, 2023

Conversation

BastiLu
Copy link
Contributor

@BastiLu BastiLu commented May 10, 2023

What this pr does

Enables to resolve a solr response when multiple sortings are passed as argument.

How to test

  1. Configure multiple sorting options (see attached img)
  2. Pass multiple sorting options to the searchrequest (see attached img)

Images

Bildschirmfoto vom 2023-05-10 16-48-54
Bildschirmfoto vom 2023-05-10 16-51-01

Fixes: #3627

@dkd-kaehm
Copy link
Collaborator

@BastiLu thanks for fixing that issue.
The Github-Actions are not triggered. Please rebase to the current state of TYPO3-Solr/ext-solr/main branch and force push to your branch.

@BastiLu
Copy link
Contributor Author

BastiLu commented May 11, 2023

@dkd-kaehm Done. My branch is already based on the current of the TYPO3-Solr/ext-solr/main branch.

@BastiLu
Copy link
Contributor Author

BastiLu commented Aug 21, 2023

Hello @dkd-kaehm friendly reminder of what is missing to merge this pr?

I also realized, that it would be great to backport this pr to at least version 11.5. What is your workflow for that? Creating a new pr?

When multiple sorting options are passed as an argument the solr server response was not resolved correctly which lead to an TYPO3 Exception.

Fixes: #3627
@dkd-kaehm dkd-kaehm merged commit 358c49f into TYPO3-Solr:main Oct 12, 2023
8 checks passed
dkd-kaehm pushed a commit that referenced this pull request Oct 12, 2023
When multiple sorting options are passed as an argument the solr server response was not resolved correctly which lead to an TYPO3 Exception.

Fixes: #3627
Ports: #3628
@dkd-kaehm dkd-kaehm mentioned this pull request Oct 13, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Exception when passing multiple sorting options
3 participants