Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Remove unused tx_solr_cache DB tables #3638

Merged
merged 2 commits into from
May 30, 2023
Merged

Conversation

bmack
Copy link
Collaborator

@bmack bmack commented May 16, 2023

What this pr does

There are SQL CREATE TABLE definitions for tx_solr_cache and tx_solr_cache_tags.

These tables have been added back then when TYPO3 did not always create cache tables.

However, since TYPO3 v9, these tables have been renamed and are automatically created, so the SQL definition can be removed.

The SQL tables are not referenced anywhere in the current source code.

How to test

Re-install the extension, drop the tables and see if everything still works.

Fixes: #3636

These tables have been added back then when
TYPO3 did not always create cache tables.

However, since TYPO3 v9, these tables
have been renamed and are automatically created,
so the SQL definition can be removed.

The SQL tables are not referenced anywhere in the
current source code.

Fixes: 3636
Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dkd-kaehm dkd-kaehm merged commit 15891e1 into TYPO3-Solr:main May 30, 2023
@dkd-kaehm dkd-kaehm mentioned this pull request Oct 13, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] tx_solr_cache DB tables to be removed?
2 participants