Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Improve Solr reports output #3655

Conversation

dkd-friedrich
Copy link
Member

What this pr does

  • [TASK] Improve Solr reports output
  • [TASK] Remove obsolete PHP filter_var report
  • [TASK] Simplify report registration

How to test

Check reports module in TYPO3 backend

Fixes: #3567

TYPO3 12 detects report modules that implement StatusProviderInterface
automatically, if autoconfigure is enabled. Thus there is no need to
register reports manually, instead autoconfigure is enabled for our
report classes.

Resolves: TYPO3-Solr#3567
A bug in filter_var() reported back in 2010 is still checked by our
report FilterVarStatus, bug and report are obsolete and thus removed.

Resolves: TYPO3-Solr#3567
@dkd-friedrich dkd-friedrich force-pushed the task/main/3567-improve_and_clean_reports branch from b5dc769 to 4f0c2e6 Compare June 1, 2023 14:31
Improves the report messages. e.g. to indicate the status of all Solr
components, success messages should be displayed too. This commit adapts
the reports to print additional information and to avoid empty report
sections.

Resolves: TYPO3-Solr#3567
@dkd-friedrich dkd-friedrich force-pushed the task/main/3567-improve_and_clean_reports branch from 4f0c2e6 to 2daefe6 Compare June 1, 2023 15:23
Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Can be merged if ready.

@dkd-kaehm dkd-kaehm merged commit ae3aef1 into TYPO3-Solr:main Jun 2, 2023
@dkd-kaehm dkd-kaehm mentioned this pull request Oct 13, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK:T12] Reports: Make them compatible to \TYPO3\CMS\Reports\StatusProviderInterface
2 participants