[TASK] Merge EXT:solrfluidgrouping into EXT:solr #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkd-friedrich
force-pushed
the
migrateExtSolrfluidgrouping
branch
from
a7b31ee
to
b0043df
Compare
|
I've pushed some adjustments and bugfixes, but there is still an issue with "allowGetParameterSwitch" and parameter |
dkd-friedrich
force-pushed
the
migrateExtSolrfluidgrouping
branch
2 times, most recently
from
d806167
to
589b8d2
Compare
Just pushed the adaptions, this includes additions to persist the |
dkd-kaehm
requested changes
Jun 5, 2023
dkd-friedrich
force-pushed
the
migrateExtSolrfluidgrouping
branch
from
589b8d2
to
34003a8
Compare
- Migrate s:translate to f:translate - Set request for fluid rendering context - Add and repair tests for solr fluid grouping feature - Check array key before use in condition - Prevent rendering groups with 0 results - Move grouping component up to the other solr components - Deactivate variant feature, if grouping feature is active - Update documentation for grouping feature - Remove old txt files for TypoScript - Add a warning about the grouping feature to docs - Migrate to PSR-14 events Resolves: TYPO3-Solr#3631
Adds basic grouping configuration to default TypoScript, grouping is disabled by default.
Fixes the HTML structure of the results template to prevent duplicate and wrong results with activated grouping.
Grouped suggest is automatically activated if grouping is activated, as there are examples for grouping and suggest, there is no need for a separate example.
EXT:solrfluidgrouping is merged in EXT:solr 12, thus older versions doesn't support grouping feature and still require extension solrfluidgrouping. This commit adapts the documentation to clearify the requirements for grouping.
dkd-friedrich
force-pushed
the
migrateExtSolrfluidgrouping
branch
2 times, most recently
from
45dfd45
to
7acab5a
Compare
Fix handling of GET parameter tx_solr[grouping]=off, due too basic grouping support in the core extension disabling the grouping via GET parameter was not possible. This commit fixes this issue by refactoring the paramter check and disabling of the grouping components.
dkd-friedrich
force-pushed
the
migrateExtSolrfluidgrouping
branch
from
7acab5a
to
6edb3e9
Compare
dkd-friedrich
requested review from
dkd-kaehm
and removed request for
dkd-friedrich
Adaptions for PSR changes done
I squashed all commits containing the initial merge, but I would prefer to keep at least the changes and additional bugfixes separately |
bmack
approved these changes
Jun 6, 2023
bmack
approved these changes
Jun 6, 2023
dkd-kaehm
changed the title
dkd-kaehm
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Migrate EXT:solrfluidgrouping into EXT:solr
Fixes: #3631