Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend user should not be logged out after editing content on hidden pages #3719

Closed
wants to merge 1 commit into from
Closed

Backend user should not be logged out after editing content on hidden pages #3719

wants to merge 1 commit into from

Conversation

dmitryd
Copy link
Contributor

@dmitryd dmitryd commented Jul 7, 2023

What this pr does

This PR adds a check for page's "hidden" property because hidden pages cannot normally be used for initializing TSFE.

How to test

Have a tree like this:

|- Root
    |- Folder
        |- Hidden page

Try editing content on the hidden page.

Fixes: #3702

@dmitryd dmitryd mentioned this pull request Jul 7, 2023
Merged
@dmitryd
Copy link
Contributor Author

dmitryd commented Jul 7, 2023

I would recommend to merge #3720 instead because it does the same as this one plus more.

@dmitryd dmitryd changed the title Fix #3702: backend user should not be logged out after editing content on hidden pages Backend user should not be logged out after editing content on hidden pages Jul 7, 2023
dkd-kaehm pushed a commit that referenced this pull request Jul 20, 2023
@dmitryd
[FEATURE] enable time-limited pages to be indexed automatically
4dd5d41 
This change allows to pages with publish time in future to be added to the index queue for automatic indexing when they go public.

Fixes: #3547, #3702
Replaces: #3719
@dkd-kaehm dkd-kaehm closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Backend User gets logged out when editing page content on a hidden page beneath a Sys-Folder
2 participants
@dmitryd @dkd-kaehm