[BUGFIX] Fix TypeError in SearchFormViewHelper #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkd-kaehm
approved these changes
Jul 14, 2023
|
@dkd-kaehm |
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
May 7, 2024
…lper
Problem:
Calling the `s:searchForm` ViewHelper with the `pageType` or `suggestPageType` argument with a value from a typoscript setting will lead to a TypeError
```html
<s:searchForm pageType="{settings.pageType}" suggestPageType="{settings.suggestPageType}">
```
`TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::setTargetPageType(): Argument #1 ($targetPageType) must be of type int, string given, called in /var/www/html/private/typo3conf/ext/solr/Classes/ViewHelpers/SearchFormViewHelper.php`
Solution:
Cast both arguments to int
Fixes: TYPO3-Solr#3927
Ports: TYPO3-Solr#3728
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
May 7, 2024
…lper
Problem:
Calling the `s:searchForm` ViewHelper with the `pageType` or `suggestPageType` argument with a value from a typoscript setting will lead to a TypeError
```html
<s:searchForm pageType="{settings.pageType}" suggestPageType="{settings.suggestPageType}">
```
`TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::setTargetPageType(): Argument #1 ($targetPageType) must be of type int, string given, called in /var/www/html/private/typo3conf/ext/solr/Classes/ViewHelpers/SearchFormViewHelper.php`
Solution:
Cast both arguments to int
Fixes: TYPO3-Solr#3927
Ports: TYPO3-Solr#3728
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
May 7, 2024
…lper
Problem:
Calling the `s:searchForm` ViewHelper with the `pageType` or `suggestPageType` argument with a value from a typoscript setting will lead to a TypeError
```html
<s:searchForm pageType="{settings.pageType}" suggestPageType="{settings.suggestPageType}">
```
`TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::setTargetPageType(): Argument #1 ($targetPageType) must be of type int, string given, called in /var/www/html/private/typo3conf/ext/solr/Classes/ViewHelpers/SearchFormViewHelper.php`
Solution:
Cast both arguments to int
Fixes: TYPO3-Solr#3927
Ports: TYPO3-Solr#3728
dkd-kaehm
added a commit
that referenced
this pull request
May 7, 2024
…lper
Problem:
Calling the `s:searchForm` ViewHelper with the `pageType` or `suggestPageType` argument with a value from a typoscript setting will lead to a TypeError
```html
<s:searchForm pageType="{settings.pageType}" suggestPageType="{settings.suggestPageType}">
```
`TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::setTargetPageType(): Argument #1 ($targetPageType) must be of type int, string given, called in /var/www/html/private/typo3conf/ext/solr/Classes/ViewHelpers/SearchFormViewHelper.php`
Solution:
Cast both arguments to int
Fixes: #3927
Ports: #3728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Calling the
s:searchFormViewHelper with thepageTypeorsuggestPageTypeargument with a value from a typoscript setting will lead to a TypeErrorTYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::setTargetPageType(): Argument #1 ($targetPageType) must be of type int, string given, called in /var/www/html/private/typo3conf/ext/solr/Classes/ViewHelpers/SearchFormViewHelper.phpSolution:
Cast both arguments to int