Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Log solr response in case of Page indexing issue #3847

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[TASK] Log solr response in case of Page indexing issue #3847

merged 1 commit into from
Oct 26, 2023

Conversation

DanielSiepmann
Copy link
Contributor

@DanielSiepmann DanielSiepmann commented Oct 26, 2023

Logging the response eases debugging.
Integrators and developers can check the response in order to retrieve the actual reported issue, a crucial info in order to fix indexing issues.

What this pr does

Add an error log entry with solr response body in case indexing a page did not succeed.

How to test

Create a broken page indexing and check the log for the new entry.

Fixes: #3846, #2590

Logging the response eases debugging.
Integrators and developers can check the response in order to retrieve
the actual reported issue, a crucial info in order to fix indexing
issues.
Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielSiepmann
Thanks for the fix.

@dkd-kaehm dkd-kaehm merged commit 8bc498e into TYPO3-Solr:main Oct 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Make debugging of failed page indexing easier
2 participants