[BUGFIX] false as field value is not allowed #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractIndexer::addDocumentFieldsFromTyposcript() disallows any PHPs empty value. This change adds explicit checks for disallowed values: * null * empty string * empty array Fixes: #3900
|
I would like to see this change reversed! "FALSE" is also a sensible value that should be saved. |
@mr-typo3 |
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Mar 7, 2024
This change is a follow-up of TYPO3-Solr#3901, which was introduced to allow following values in Apache Solr fields: * numeric 0 * boolean false which lead to countless-unwanted numeric fields with 0 value in Apache Solr documents. The background: TypoScript can return the strings only, and all empty values lead to numeric 0. This change tries to avoid mispelled casting of numbers and lets the `AbstractIndexer::ensureFieldValueType()` return PHPs `null` if the value isn't a number. Relates: TYPO3-Solr#3900, TYPO3-Solr#3901
dkd-friedrich
pushed a commit
that referenced
this pull request
Mar 7, 2024
This change is a follow-up of #3901, which was introduced to allow following values in Apache Solr fields: * numeric 0 * boolean false which lead to countless-unwanted numeric fields with 0 value in Apache Solr documents. The background: TypoScript can return the strings only, and all empty values lead to numeric 0. This change tries to avoid mispelled casting of numbers and lets the `AbstractIndexer::ensureFieldValueType()` return PHPs `null` if the value isn't a number. Relates: #3900, #3901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractIndexer::addDocumentFieldsFromTyposcript()disallows any PHPs empty value. This change adds explicit checks for disallowed values:Fixes: #3900