Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix debug output if response body is read once stream #4009

Merged
merged 1 commit into from
May 7, 2024

Conversation

Kanti
Copy link
Contributor

@Kanti Kanti commented Apr 16, 2024

Problem:

We had the problem that the requests where cached by staticfilecache.
But we could not find any hint about that in the logs.

Because the log would only show an empty body.

That is because the body was already read in the lines above the log message.
And it was a read once stream. (read more about read once streams: https://stackoverflow.com/a/6518288/5440709 )

Solution:

Our solution is to keep the body in a variable so if there is a Problem we can send the body to the log message.

@dkd-kaehm

@dkd-kaehm
Copy link
Collaborator

@Kanti
Thanks for the fix, but what does it exactly?
Please add the description properly.

Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix and description.

@dkd-kaehm dkd-kaehm merged commit f1f3aa8 into TYPO3-Solr:main May 7, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants