[TASK] Do not ignore database exceptions #4200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a try catch block around a select query. When a database query is not okay for any reason, then i like to get the reason directly.
|
I agree that muted exceptions are a no-go, but IMHO a proper handling is much better than letting the application break with an unhandled exception. And there are already enough of completely unhelpful stack traces in logs created by Solr. I suggest at least logging the SQL statement and the context in some readable manner before letting the calling code choke on the exception. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
This removes a try catch block around a select query.
When a database query is not okay for any reason, then i like to get the reason directly.
Fixes: #4199