Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added arbitratorAdded and arbitratorRemoved events #196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added arbitratorAdded and arbitratorRemoved events #196

wants to merge 2 commits into from

Conversation

yashgo0018
Copy link
Member

New PR:

Useful info

Auto-Review checklist

  • Check if there is no merge conflict
  • If you have new .env variable, check if you add it in the .env.example file

Typing

  • Check lint feedbacks: npm run lint
  • Check prettier format feedbacks: npm run format

0xRomain
0xRomain reviewed Oct 16, 2023
View reviewed changes
contracts/TalentLayerPlatformID.sol Outdated
@@ -151,6 +151,7 @@ contract TalentLayerPlatformID is ERC721Upgradeable, AccessControlUpgradeable, U
// Increment counter to start platform ids at index 1
nextPlatformId.increment();
mintStatus = MintStatus.ONLY_WHITELIST;
emit ArbitratorAdded(address(0), false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this will not work as initialize will not be called after an upgrade, we need to create a new V2 here. Check doc https://docs.openzeppelin.com/contracts/4.x/api/proxy#Initializable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the line

@0xRomain 0xRomain self-assigned this Oct 16, 2023
@0xRomain 0xRomain added the NEED FIX CODE Dev needs to check feedbacks from review and act on it label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xRomain 0xRomain 0xRomain left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@0xRomain 0xRomain

Labels
NEED FIX CODE Dev needs to check feedbacks from review and act on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashgo0018 @0xRomain