Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Unpin constraints via impl collision #31

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Tamschi
Copy link
Owner

@Tamschi Tamschi commented Jan 2, 2021

If trait overlap detection was more accurate, it would be possible to forbid unsound Unpin implementations much more ergonomically (showing a very descriptive trait name with associated documentation in the error). However, this is currently blocked by rust-lang/rust#50551 Coherence rules are not consistent when applied to auto traits issue status.

Alternatively, this pull request could be made obsolete using const asserts based on min_specialization, via rust-lang/rust#31844 "Tracking issue for specialization (RFC 1210)" issue status.

@Tamschi Tamschi added help wanted Extra attention is needed blocked This waits on some other issue, either in this repository or elsewhere labels Jan 2, 2021
@Tamschi
Copy link
Owner Author

Tamschi commented Jan 14, 2022

This can likely be done nicely using const panics now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This waits on some other issue, either in this repository or elsewhere help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant