Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add experimental beforeQuery and afterQuery queryClient options #7650

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

tannerlinsley
Copy link
Collaborator

@tannerlinsley tannerlinsley commented Jun 30, 2024

These experimental hooks will give me everything I need to write a full integration for TanStack Router. If they work out well, we can either find better names/locations/implementations for them, or stick with them and document them.

Copy link

vercel bot commented Jun 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jun 30, 2024 5:44am

Copy link

nx-cloud bot commented Jun 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 36e1959. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@tannerlinsley tannerlinsley force-pushed the experimental-before-after-suspense branch from 7a519c6 to 97d9516 Compare June 30, 2024 04:49
Copy link

codesandbox-ci bot commented Jun 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 36e1959:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@tannerlinsley tannerlinsley force-pushed the experimental-before-after-suspense branch from 97d9516 to 9e16b9a Compare June 30, 2024 04:50
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (f454bf1) to head (d83cb4d).

Current head d83cb4d differs from pull request most recent head 36e1959

Please upload reports for the commit 36e1959 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7650       +/-   ##
===========================================
+ Coverage   44.07%   86.16%   +42.09%     
===========================================
  Files         185       24      -161     
  Lines        7052      318     -6734     
  Branches     1551       81     -1470     
===========================================
- Hits         3108      274     -2834     
+ Misses       3578       37     -3541     
+ Partials      366        7      -359     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query 93.01% <100.00%> (+0.07%) ⬆️
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@tannerlinsley tannerlinsley force-pushed the experimental-before-after-suspense branch from 9e16b9a to d83cb4d Compare June 30, 2024 05:24
@tannerlinsley tannerlinsley changed the title fix: add experimental beforeSuspend and afterSuspend queryClient options fix: add experimental beforeQuery and afterQuery queryClient options Jun 30, 2024
@tannerlinsley tannerlinsley force-pushed the experimental-before-after-suspense branch from d83cb4d to 60014f2 Compare June 30, 2024 05:43
@tannerlinsley tannerlinsley force-pushed the experimental-before-after-suspense branch from 60014f2 to 36e1959 Compare June 30, 2024 05:43
@tannerlinsley tannerlinsley merged commit 8927e4c into main Jun 30, 2024
6 checks passed
@tannerlinsley tannerlinsley deleted the experimental-before-after-suspense branch June 30, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant