Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(solid-query): export InitialDataOptions types #7707

Merged
merged 2 commits into from
Jul 11, 2024
Merged

fix(solid-query): export InitialDataOptions types #7707

merged 2 commits into from
Jul 11, 2024

Conversation

Brendonovich
Copy link
Contributor

@Brendonovich Brendonovich commented Jul 10, 2024 •
edited
Loading

These types are exported from react query but not solid query

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 10, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a1a2512. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 10, 2024 •
edited
Loading

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: a1a2512

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7707

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7707

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7707

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7707

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7707

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7707

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7707

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7707

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7707

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7707

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7707

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7707

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7707

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7707

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7707

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7707

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7707

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7707

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7707

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7707

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7707

templates

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.33%. Comparing base (5c9efe8) to head (a1a2512).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7707       +/-   ##
===========================================
+ Coverage   44.56%   79.33%   +34.76%     
===========================================
  Files         185       13      -172     
  Lines        7062      329     -6733     
  Branches     1554       62     -1492     
===========================================
- Hits         3147      261     -2886     
+ Misses       3552       56     -3496     
+ Partials      363       12      -351
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query 78.06% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@lachlancollins lachlancollins merged commit 1846abe into TanStack:main Jul 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlancollins lachlancollins lachlancollins approved these changes

Assignees
No one assigned
Labels
package: solid-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brendonovich @lachlancollins