Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): query should reset to default state even when created from hydration #7837

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Aug 1, 2024

fixes #6682

Copy link

nx-cloud bot commented Aug 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 95b4798. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Aug 1, 2024

commit: 95b4798

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7837
pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@7837
pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@7837
pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@7837
pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7837
pnpm add https://pkg.pr.new/@tanstack/query-core@7837
pnpm add https://pkg.pr.new/@tanstack/query-devtools@7837
pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@7837
pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@7837
pnpm add https://pkg.pr.new/@tanstack/react-query@7837
pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@7837
pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@7837
pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@7837
pnpm add https://pkg.pr.new/@tanstack/solid-query@7837
pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@7837
pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@7837
pnpm add https://pkg.pr.new/@tanstack/svelte-query@7837
pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@7837
pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@7837
pnpm add https://pkg.pr.new/@tanstack/vue-query@7837
pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@7837

Open in Stackblitz

More templates

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.26%. Comparing base (c7245c9) to head (95b4798).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7837       +/-   ##
===========================================
+ Coverage   44.61%   63.26%   +18.65%     
===========================================
  Files         185      125       -60     
  Lines        7087     4533     -2554     
  Branches     1574     1261      -313     
===========================================
- Hits         3162     2868      -294     
+ Misses       3562     1437     -2125     
+ Partials      363      228      -135     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 92.82% <100.00%> (ø)
@tanstack/query-devtools 5.24% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 92.44% <ø> (ø)
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.42% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit bbb2244 into main Aug 1, 2024
8 checks passed
@TkDodo TkDodo deleted the feature/reset branch August 1, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#initialState set incorrectly to persisted state
1 participant