fix(types): error booleans shouldn't permanently be typed as `false` #7956

TkDodo · 2024-08-26T17:20:07Z

nx-cloud · 2024-08-26T17:20:31Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e2948d3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

pkg-pr-new · 2024-08-26T17:22:44Z

commit: e2948d3

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7956

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@7956

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@7956

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@7956

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7956

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@7956

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@7956

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@7956

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@7956

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@7956

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@7956

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@7956

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@7956

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@7956

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@7956

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@7956

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@7956

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@7956

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@7956

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@7956

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@7956

Open in Stackblitz

More templates

codecov · 2024-08-26T17:51:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.29%. Comparing base (8cf7e2f) to head (e2948d3).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##           main    #7956       +/-   ##
=========================================
+ Coverage      0   63.29%   +63.29%     
=========================================
  Files         0      127      +127     
  Lines         0     4536     +4536     
  Branches      0     1262     +1262     
=========================================
+ Hits          0     2871     +2871     
- Misses        0     1437     +1437     
- Partials      0      228      +228

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`86.58% <ø> (∅)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`43.85% <ø> (∅)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`92.83% <ø> (∅)`
@tanstack/query-devtools	`5.24% <ø> (∅)`
@tanstack/query-persist-client-core	`57.73% <ø> (∅)`
@tanstack/query-sync-storage-persister	`82.50% <ø> (∅)`
@tanstack/react-query	`92.50% <ø> (∅)`
@tanstack/react-query-devtools	`10.71% <ø> (∅)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (∅)`
@tanstack/solid-query	`78.20% <ø> (∅)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (∅)`
@tanstack/svelte-query	`87.33% <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (∅)`
@tanstack/vue-query	`71.42% <ø> (∅)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

fix(types): error booleans shouldn't permanently be typed as false

0449c4c

github-actions bot added package: react-query package: query-core labels Aug 26, 2024

TkDodo added 3 commits August 26, 2024 19:23

Merge branch 'main' into feature/refetch-boolean-types

0102a1f

fix(types): error booleans shouldn't permanently be typed as false

9dbd88a

chore: I don't understand these errors

e2948d3

github-actions bot added the package: solid-query label Aug 26, 2024

TkDodo merged commit b93941d into main Aug 26, 2024
8 checks passed

TkDodo deleted the feature/refetch-boolean-types branch August 26, 2024 17:52

This was referenced Sep 17, 2024

[Snyk] Upgrade: , , zntb/crypto-ticker#46

Merged

[Snyk] Upgrade @tanstack/react-query from 5.52.1 to 5.52.2 zntb/ReactEvents-With-TanStack-Query#19

Merged

[Snyk] Upgrade @tanstack/react-query from 5.52.1 to 5.52.2 zntb/nextjs-web3-app-zksync#62

Merged

thaiduy0282 mentioned this pull request Sep 17, 2024

[Snyk] Upgrade: , , , zustand, , , , antd, react-router-dom, reactflow, styled-components thaiduy0282/workflow_ui#3

Open

sebastien-comeau mentioned this pull request Sep 17, 2024

[Snyk] Upgrade @tanstack/react-query from 5.51.23 to 5.52.2 DTS-STN/senior-journey#713

Open

ypreiser mentioned this pull request Sep 17, 2024

[Snyk] Upgrade @tanstack/react-query from 5.52.1 to 5.52.2 ypreiser/TDD#3

Merged

thaiduy0282 mentioned this pull request Sep 18, 2024

[Snyk] Upgrade: , , , zustand, , , , antd, react-router-dom, reactflow, styled-components thaiduy0282/workflow_ui#4

Open

danial117 mentioned this pull request Sep 18, 2024

[Snyk] Upgrade: , , , , , , axios, react-router-dom danial117/Pharma#40

Open

OATEF4313 mentioned this pull request Sep 18, 2024

[Snyk] Upgrade @tanstack/react-query from 5.45.1 to 5.52.2 OATEF4313/wagmi#1

Open

danial117 mentioned this pull request Sep 19, 2024

[Snyk] Upgrade: , , , , , , axios, react-router-dom danial117/Pharma#41

Open

thaiduy0282 mentioned this pull request Sep 19, 2024

[Snyk] Upgrade: , , , zustand, , , , antd, react-router-dom, reactflow, styled-components thaiduy0282/workflow_ui#5

Open

danial117 mentioned this pull request Sep 20, 2024

[Snyk] Upgrade: , , , , , , axios, react-router-dom danial117/Pharma#47

Open

This was referenced Sep 21, 2024

[Snyk] Upgrade @tanstack/react-query from 5.52.2 to 5.53.1 zntb/ReactEvents-With-TanStack-Query#20

Open

[Snyk] Upgrade: , , zntb/crypto-ticker#47

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(types): error booleans shouldn't permanently be typed as `false` #7956

fix(types): error booleans shouldn't permanently be typed as `false` #7956

TkDodo commented Aug 26, 2024

nx-cloud bot commented Aug 26, 2024 •

edited

Loading

pkg-pr-new bot commented Aug 26, 2024 •

edited

Loading

codecov bot commented Aug 26, 2024 •

edited

Loading

fix(types): error booleans shouldn't permanently be typed as false #7956

fix(types): error booleans shouldn't permanently be typed as false #7956

Conversation

TkDodo commented Aug 26, 2024

nx-cloud bot commented Aug 26, 2024 • edited Loading

☁️ Nx Cloud Report

pkg-pr-new bot commented Aug 26, 2024 • edited Loading

codecov bot commented Aug 26, 2024 • edited Loading

Codecov Report

fix(types): error booleans shouldn't permanently be typed as `false` #7956

fix(types): error booleans shouldn't permanently be typed as `false` #7956

nx-cloud bot commented Aug 26, 2024 •

edited

Loading

pkg-pr-new bot commented Aug 26, 2024 •

edited

Loading

codecov bot commented Aug 26, 2024 •

edited

Loading