fix: id building was not consistent when using deep accessorKey (4754) (

#5430) * fix: id building was not consistent when using deep accessorKey (4754) * ci: apply automated fixes --------- Co-authored-by: Kevin Van Cott <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
TanStack · Aug 3, 2024 · 84cf73a · 84cf73a
1 parent 55da0c3
commit 84cf73a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/table-core/src/core/column.ts b/packages/table-core/src/core/column.ts
@@ -79,7 +79,11 @@ export function createColumn<TData extends RowData, TValue>(
 
   let id =
     resolvedColumnDef.id ??
-    (accessorKey ? accessorKey.replace('.', '_') : undefined) ??
+    (accessorKey
+      ? typeof String.prototype.replaceAll === 'function'
+        ? accessorKey.replaceAll('.', '_')
+        : accessorKey.replace(/\./g, '_')
+      : undefined) ??
     (typeof resolvedColumnDef.header === 'string'
       ? resolvedColumnDef.header
       : undefined)