S10 overshoot fix #237
Merged
S10 overshoot fix #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @AJScanlan, thanks for your PR! Looks good to me. I've wrestled with this in the past, and the original padding value was arbitrarily chosen. I think in the future I may change it to a calculated percentage of the screen. I've just merged another PR, which bumps the version to 6.2.0. Could you alter your PR version to 6.2.1 in the build.gradle, and the changelog - then I'll merge? |
|
Yeah I was considering something similar to calculating the height but didn't want to mess with it too much since I don't know fully how it all works and didn't want to break this very popular library ;) Sure thing, I'll update now |
…shoot_fix # Conflicts: # CHANGELOG.md # alerter/build.gradle
kpmmmurphy
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kpmmmurphy finally got a chance to use this library :D
Noticed some overshooting on my S10 though, quickest way I thought to fix was increase the negative margins. This works but moves the alert up slightly in its resting position versus the original margins.
To my eye it's ok but if you think it will cause issues let me know if there's a better way, been a while since I did Android.