[Network] #105 - Univ Select API 연동 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Hankkijogbo/Hankkijogbo/Application/SceneDelegate.swift Hankkijogbo/Hankkijogbo/Present/CreateZip/ViewModel/CreateZipViewModel.swift
EunsuSeo01
approved these changes
Jul 18, 2024
Comment on lines
+29
to
+34
| private var titleButtonAction: ButtonAction? { | ||
| didSet { | ||
| let tapGesture = UITapGestureRecognizer(target: self, action: #selector(titleButtonDidTap)) | ||
| titleStackView.addGestureRecognizer(tapGesture) | ||
| } | ||
| } |
There was a problem hiding this comment.
p2: titleButtonDidTap이라고 해서 내 titleButton을 찾아 조금 헤매었다오. 나의 아기 벗이여, 혹시 직관적으로 titleStackViewDidTap은 어떠한가?
There was a problem hiding this comment.
음 근데, 토글 버튼도 있어서 button으로 두었소....
Comment on lines
+31
to
+37
| func saveUniversity(_ university: UniversityModel) { | ||
| print("대학정보 저장") | ||
| let defaults = UserDefaults.standard | ||
| if let encoded = try? JSONEncoder().encode(university) { | ||
| defaults.set(encoded, forKey: "university") | ||
| } | ||
| } |
Comment on lines
+69
to
+82
| func postReissue(completion: @escaping (NetworkResult<PostReissueResponseData>) -> Void) { | ||
| provider.request(.postReissue) { result in | ||
| switch result { | ||
| case .success(let response): | ||
| let networkResult: NetworkResult<PostReissueResponseData> = self.fetchNetworkResult(statusCode: response.statusCode, data: response.data) | ||
| completion(networkResult) | ||
| case .failure(let error): | ||
| if let response = error.response { | ||
| let networkResult: NetworkResult<PostReissueResponseData> = self.fetchNetworkResult(statusCode: response.statusCode, data: response.data) | ||
| completion(networkResult) | ||
| } | ||
| } | ||
| } | ||
| } |
mcrkgus
approved these changes
Jul 18, 2024
| @@ -27,9 +27,32 @@ extension UserDefaults { | |||
| func getAccesshToken() -> String { | |||
| return UserDefaults.standard.string(forKey: UserDefaultsKey.accessToken.rawValue) ?? "" | |||
| } | |||
|
|
|||
| func saveUniversity(_ university: UniversityModel) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Pull requests
👷 작업한 내용
🚨 참고 사항
University정보를 User Default 에 저장합니다.대학 이름은 이런식으로 가져오면 됩니다. (다른 것도 동일함)
📸 스크린샷
✅ Check List
📟 관련 이슈