Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #126 - ShowAlert 에러 처리 #129

Merged
merged 3 commits into from
Jul 19, 2024
Merged

[Feat] #126 - ShowAlert 에러 처리 #129

merged 3 commits into from
Jul 19, 2024

Conversation

mcrkgus
Copy link
Member

@mcrkgus mcrkgus commented Jul 19, 2024

🔥 Pull requests

👷 작업한 내용

  • 에러처리를 위한 모든 에러 화면에서 alert 창 표출

🚨 참고 사항

  • 이미지 변경 부탁드려요 서현양

✅ Check List

  • Merge 대상 브랜치가 올바른가?
  • 최종 코드가 에러 없이 잘 동작하는가?
  • 전체 변경사항이 500줄을 넘지 않는가?

📟 관련 이슈

@mcrkgus mcrkgus added 🍚 Feat 새로운 기능 구현 💞 가현 가현 공주 작업 labels Jul 19, 2024
@mcrkgus mcrkgus requested a review from EunsuSeo01 July 19, 2024 11:23
@mcrkgus mcrkgus self-assigned this Jul 19, 2024
@mcrkgus mcrkgus requested a review from shimseohyun July 19, 2024 11:25
Copy link
Contributor

@shimseohyun shimseohyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

Comment on lines 31 to 34
case .unAuthorized, .networkFail:
self?.showAlert?("Failed")
print("FAILED")
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에러처리는 이 두 분기에서만 하나요?

Copy link
Member

@EunsuSeo01 EunsuSeo01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가자

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내 폴더... 돌리도

@@ -10,6 +10,7 @@ import Foundation
import Moya

final class HankkiDetailViewModel {
var showAlert: ((String) -> Void)?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿

@mcrkgus mcrkgus merged commit 18cc32f into develop Jul 19, 2024
@mcrkgus mcrkgus deleted the chore/#126 branch July 19, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍚 Feat 새로운 기능 구현 💞 가현 가현 공주 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore] Detail 수정
3 participants