Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network] #128 - HankkiList Heart API 연동 #130

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Conversation

shimseohyun
Copy link
Contributor

🔥 Pull requests

👷 작업한 내용

  • 한끼 리스트의 하트 버튼에 API를 연동했습니다.

✅ Check List

  • Merge 대상 브랜치가 올바른가?
  • 최종 코드가 에러 없이 잘 동작하는가?
  • 전체 변경사항이 500줄을 넘지 않는가?

📟 관련 이슈

@shimseohyun shimseohyun added 🤹🏻‍♀️ 서현 서현 공주 작업 🛜 Network API 연결 labels Jul 19, 2024
@shimseohyun shimseohyun self-assigned this Jul 19, 2024
Copy link
Member

@EunsuSeo01 EunsuSeo01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿

Copy link
Member

@mcrkgus mcrkgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -19,6 +19,7 @@ final class HankkiListViewModel {

var hankkiList: [HankkiListTableViewCell.DataStruct] = [] {
didSet {
print("다시로드~~~~~~~~~~~~~~~~~~~~~~~~~\n", hankkiList)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3
지워주세요

print("SUCCESS")
completion()
case .unAuthorized, .networkFail:
print("FAILED")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

showAlert 넣어주세요

print("SUCCESS")
completion()
case .unAuthorized, .networkFail:
print("FAILED")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

showAlert 넣어주세요

@shimseohyun shimseohyun merged commit 6b85306 into develop Jul 19, 2024
@shimseohyun shimseohyun deleted the network/#128 branch July 19, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛜 Network API 연결 🤹🏻‍♀️ 서현 서현 공주 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Network] HankkiList 좋아요 토글
3 participants