[Fix] #148 - 공용 컴포넌트 생성 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimseohyun
approved these changes
Aug 5, 2024
Comment on lines
37
to
39
| let width = max(size.width + 20, minimumWidth) | ||
| let height = size.height + 10 | ||
| return CGSize(width: width, height: height) |
There was a problem hiding this comment.
이렇게 패딩값을 지정하다니 아주 좋은 생각이오.
Comment on lines
34
to
41
| // 글자 수에 따라 tag 사이즈 조정 | ||
| override var intrinsicContentSize: CGSize { | ||
| let size = super.intrinsicContentSize | ||
| let width = max(size.width + 20, minimumWidth) | ||
| let height = size.height + 10 | ||
| return CGSize(width: width, height: height) | ||
| } | ||
| } |
There was a problem hiding this comment.
p2:
코드를 깊게 탐구하다 문득 든 생각이오.
카테고리 태그 이외에도 이러한 둥근 태그 형태는 이곳저곳에서 많이 사용되는 것으로 아는데, 이것을 extesion으로 빼면 조금 효과적으로 사용할 수 있지 않을까라는 생각이 들고 있소
그대 생각은 어떠하오?
There was a problem hiding this comment.
음 공용 컴포넌트로 관리하는게 좋을 것 같아유
소녀 말에 의하면 자주 사용되는 컴포넌트(버튼, 토스트메세지, 얼럿)들도 extension으로 빼는 방법일텐데... 기준이 모호해질것 같소
기본적인 속성들만 확장시키는 것이 더 좋을 듯 하옵니다
Comment on lines
25
to
32
| extension HankkiAPIServiceProtocol { | ||
| typealias GetCategoryFilterResponseDTO = BaseDTO<GetCategoryFilterResponseData> | ||
| typealias GetPriceFilterResponseDTO = BaseDTO<GetPriceFilterResponseData> | ||
| typealias GetSortOptionFilterResponseDTO = BaseDTO<GetSortOptionFilterResponseData> | ||
| typealias GetHankkiListResponseDTO = BaseDTO<GetHankkiListResponseData> | ||
| typealias GetHankkiPinResponseDTO = BaseDTO<GetHankkiPinResponseData> | ||
| typealias GetHankkiThumbnailResponseDTO = BaseDTO<GetHankkiThumbnailResponseData> | ||
| typealias GetHankkiDetailResponseDTO = BaseDTO<GetHankkiDetailResponseData> |
EunsuSeo01
approved these changes
Aug 5, 2024
Comment on lines
37
to
39
| let width = max(size.width + 20, minimumWidth) | ||
| let height = size.height + 10 | ||
| return CGSize(width: width, height: height) |
Comment on lines
9
to
10
|
|
||
| class HankkiCategoryTag: UILabel { |
There was a problem hiding this comment.
p3: Components 폴더에 있는 다른 파일들처럼 이 파일을 눌러보지 않아도 Label인지 View인지 알 수 있게 HankkiCategoryTagLabel로 네이밍을 더 명확하게 하는 것은 어떤지 묻고 싶소이다.
Comment on lines
25
to
32
| extension HankkiAPIServiceProtocol { | ||
| typealias GetCategoryFilterResponseDTO = BaseDTO<GetCategoryFilterResponseData> | ||
| typealias GetPriceFilterResponseDTO = BaseDTO<GetPriceFilterResponseData> | ||
| typealias GetSortOptionFilterResponseDTO = BaseDTO<GetSortOptionFilterResponseData> | ||
| typealias GetHankkiListResponseDTO = BaseDTO<GetHankkiListResponseData> | ||
| typealias GetHankkiPinResponseDTO = BaseDTO<GetHankkiPinResponseData> | ||
| typealias GetHankkiThumbnailResponseDTO = BaseDTO<GetHankkiThumbnailResponseData> | ||
| typealias GetHankkiDetailResponseDTO = BaseDTO<GetHankkiDetailResponseData> |
| @@ -12,7 +12,7 @@ final class TotalListCollectionViewCell: BaseCollectionViewCell { | |||
| // MARK: - UI Components | |||
|
|
|||
| let thumbnailImageView: UIImageView = UIImageView() | |||
| private let menutag: UILabel = UILabel() | |||
| private let menutag: UILabel = HankkiCategoryTag() | |||
There was a problem hiding this comment.
p3: 얘도 menuTagLabel로 하면 좋을 듯하오.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Pull requests
👷 작업한 내용
🖥️ 주요 코드 설명
TotalListCollectionViewCell✅ Check List
📟 관련 이슈