-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] #48 - MyZip, Reported&Liked Hankki List #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM NICE PRINCESS μ‘°μμ
Hankkijogbo/Hankkijogbo/Present/HankkiList/View/Cell/HankkiListTableViewCell.swift
Outdated
Show resolved
Hide resolved
Hankkijogbo/Hankkijogbo/Present/HankkiList/View/Cell/HankkiListTableViewCell.swift
Outdated
Show resolved
Hide resolved
Hankkijogbo/Hankkijogbo/Present/HankkiList/View/Cell/HankkiListTableViewCell.swift
Show resolved
Hide resolved
Hankkijogbo/Hankkijogbo/Present/HankkiList/View/Cell/ZipHeaderTableView.swift
Outdated
Show resolved
Hide resolved
Hankkijogbo/Hankkijogbo/Present/HankkiList/View/Cell/ZipHeaderTableView.swift
Outdated
Show resolved
Hide resolved
Hankkijogbo/Hankkijogbo/Present/HankkiList/View/HankkiListViewController.swift
Show resolved
Hide resolved
func setupDelegate() { | ||
hankkiTableView.delegate = self | ||
hankkiTableView.dataSource = self | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3
μ€ μ§μμ£ΌμΈμ
func scrollViewDidScroll(_ scrollView: UIScrollView) { | ||
if scrollView.contentOffset.y < 0 && self.type == .myZip { | ||
scrollView.bounces = false | ||
} else { | ||
scrollView.bounces = true | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3
μ‘°μΌμΈμ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μκ³ λ§μΌμ ¨μ΅λλ€ μ κΈ°μ¨
hankkiTableView.beginUpdates() | ||
hankkiTableView.deleteRows(at: [indexPath], with: .automatic) | ||
hankkiTableView.endUpdates() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
func tableView(_ tableView: UITableView, trailingSwipeActionsConfigurationForRowAt indexPath: IndexPath) -> UISwipeActionsConfiguration? { | ||
if self.type != .myZip { | ||
return nil | ||
} | ||
|
||
let deleteAction = UIContextualAction(style: .destructive, title: "μμ ") { (_, _, completionHandler) in | ||
self.deleteItem(at: indexPath) | ||
// TODO: -api μ°λ μ λλ‘νκΈ° | ||
print(indexPath.item, "λ²μ§Έ μ μ μμ νμ΄μ!!!!!!!!!!") | ||
completionHandler(true) | ||
} | ||
deleteAction.backgroundColor = .hankkiRed | ||
|
||
let configuration = UISwipeActionsConfiguration(actions: [deleteAction]) | ||
configuration.performsFirstActionWithFullSwipe = false | ||
return configuration | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 2
var headrViewHeight: CGFloat { | ||
switch self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3: headerViewHeight
e λΉ μ‘λ€
π₯ Pull requests
π· μμ ν λ΄μ©
π¨ μ°Έκ³ μ¬ν
πΈ μ€ν¬λ¦°μ·
π₯οΈ μ£Όμ μ½λ μ€λͺ
navigation μ 컀μ€ν μ μν΄ typeμ μμ νμ΅λλ€. κΈ°λ³Έ white , μκΉ μ»€μ€ν μ νκ³ μΆμΌμλ©΄ μμ μ§μ ν΄μ μ μΈνμλ©΄ λ©λλ€.
νλΌ λ¦¬μ€νΈμ λ·°λ₯Ό 3κ°μ§ 뷰컨μ λλ €μλλ€...
myZip : λμ 쑱보μ μλ μλΉ λ¦¬μ€νΈ (μ’μμλ²νΌ μμ, ν€λ μ‘΄μ¬)
reported : μ 보ν μλΉλ¦¬μ€νΈ (μ’μμ λ²νΌ μμ)
lized : μ’μμν μλΉλ¦¬μ€νΈ (μ’μμλ²νΌ μμ)
β Check List
π κ΄λ ¨ μ΄μ