Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Network] #73 - Auth, User, Zip, University Service 추가 #83

Merged
merged 19 commits into from
Jul 17, 2024
Merged

[Network] #73 - Auth, User, Zip, University Service 추가 #83

merged 19 commits into from
Jul 17, 2024

Conversation

shimseohyun
Copy link
Contributor

🔥 Pull requests

👷 작업한 내용

  • Auth, User, Zip, University Service 추가

🖥️ 주요 코드 설명

BaseTargetType

enum UtilPath: String {
    case auth = "/v1/auth"
    case user = "/v1/users"
    case menu = "/v1/menus"
    case hankki = "/v1/stores"
    case zip = "/v1/favorites"
    case report = "/v1/reports"
    case university = "/v1/universities"
}

서버의 버전관리 이슈로, version 타입을 utilpath 의 처음 부분에서 관리합니다.

✅ Check List

  • Merge 대상 브랜치가 올바른가?
  • 최종 코드가 에러 없이 잘 동작하는가?
  • 전체 변경사항이 500줄을 넘지 않는가?

📟 관련 이슈

@shimseohyun shimseohyun added 🤹🏻‍♀️ 서현 서현 공주 작업 🛜 Network API 연결 labels Jul 17, 2024
@shimseohyun shimseohyun requested a review from mcrkgus July 17, 2024 05:21
@shimseohyun shimseohyun self-assigned this Jul 17, 2024
mcrkgus
mcrkgus approved these changes Jul 17, 2024
View reviewed changes
Hankkijogbo/Hankkijogbo/Network/User/UserTargetType.swift Outdated
Comment on lines 61 to 65
case .getMe: return .get
case .getMeUniversity: return .get
case .getMeHankkiHeartList: return .get
case .getMeHankkiReportList: return .get
case .getMeZipList: return .get
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3
한줄로 어떠실까요 공주님

EunsuSeo01
EunsuSeo01 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@EunsuSeo01 EunsuSeo01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPLE TV

Hankkijogbo/Hankkijogbo/Network/University/DTO/Response/GetUniversityListResponseDTO.swift Outdated
Comment on lines 10 to 12
struct GetUniversityListResponseDataDTO: Codable {
let universities: [GetUniversityResponseData]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetUniversityListResponseData 어떠실가요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

레전드 꼼꼼함 ㄷㄷ

Hankkijogbo/Hankkijogbo/Network/User/DTO/Response/GetMeResponseDTO.swift
Comment on lines +10 to +13
struct GetMeResponseDTO {
let nickname: String
let profileImageUrl: String
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetMeResponseData

@shimseohyun shimseohyun merged commit 138346d into develop Jul 17, 2024
@shimseohyun shimseohyun deleted the network/#73 branch July 19, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcrkgus mcrkgus mcrkgus approved these changes

@EunsuSeo01 EunsuSeo01 EunsuSeo01 approved these changes

Assignees

@shimseohyun shimseohyun

Labels
🛜 Network API 연결 🤹🏻‍♀️ 서현 서현 공주 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Network] Auth, User, Zip, University Service 추가
3 participants
@shimseohyun @EunsuSeo01 @mcrkgus