[Chore] #64 - 홈화면, 전체 족보 리스트(BottomSheet) 화면 연결 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimseohyun
approved these changes
Jul 18, 2024
Comment on lines
+29
to
+31
| super.init(frame: frame) | ||
|
|
||
| } |
Comment on lines
+56
to
+58
| thumbnailImageView.do { | ||
| $0.layer.cornerRadius = 8 | ||
| $0.backgroundColor = .gray |
There was a problem hiding this comment.
p3: 메이크 라운드 함수라는 것을 써보는건 어떠하오?
Comment on lines
+138
to
+142
| menutag.text = "#" + model.menu | ||
| hankkiTitle.text = model.hankkiTitle | ||
| priceLabel.text = String(model.price) + "원" | ||
| likeLabel.text = String(model.liked) | ||
| } |
There was a problem hiding this comment.
소인의 부분에서도 이 부분이 쓰였는데, 이 부분을 완전 까먹었었던 것 같소.
이제야 기억을 되 찾았으니 소인도 이부분을 고치겠소
Comment on lines
207
to
209
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize { | ||
| return CGSize(width: 375, height: 104) | ||
| } |
There was a problem hiding this comment.
p3 소인은 잘 모른다만, 이런다면 기기대응이 되는 것이오?
EunsuSeo01
approved these changes
Jul 18, 2024
Comment on lines
+10
to
+11
| /// HomeViewController에서 extension을 통해 Filtering Button의 속성을 변경하는 함수들을 분리 | ||
| extension HomeViewController { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Pull requests
👷 작업한 내용
전체 족보 리스트 BottomSheet핸들러 동작🚨 참고 사항
📸 스크린샷
✅ Check List
📟 관련 이슈